From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] icomplete-vertical Date: Sun, 11 Apr 2021 01:39:39 +0300 Organization: LINKOV.NET Message-ID: <87lf9pahlk.fsf@mail.linkov.net> References: <87h7kkwcy1.fsf@posteo.net> <83tuokb0uk.fsf@gnu.org> <87o8er3i8z.fsf@posteo.net> <87blar3glt.fsf@posteo.net> <87im4z1gbc.fsf@mail.linkov.net> <87eefhevye.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1269"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Gregory Heytings , emacs-devel , Eli Zaretskii , Philip Kaludercic , Stefan Monnier To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 11 00:46:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVMMh-0000CY-Sf for ged-emacs-devel@m.gmane-mx.org; Sun, 11 Apr 2021 00:46:07 +0200 Original-Received: from localhost ([::1]:54674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVMMg-00064d-TL for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 18:46:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVMLN-000581-Pq for emacs-devel@gnu.org; Sat, 10 Apr 2021 18:44:46 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:53027) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVMLL-0004Wu-Ap; Sat, 10 Apr 2021 18:44:45 -0400 X-Originating-IP: 91.129.96.157 Original-Received: from mail.gandi.net (m91-129-96-157.cust.tele2.ee [91.129.96.157]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 40AAB60008; Sat, 10 Apr 2021 22:44:37 +0000 (UTC) In-Reply-To: (=?iso-8859-1?Q?=22Jo=E3o_T=E1vora=22's?= message of "Sat, 10 Apr 2021 23:01:41 +0100") Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267843 Archived-At: >> Good to see that the new branch avoids such hacks. I tested it out, >> and everything is nice. > > Did you test the branch that me and Gregory are working > on off-list? > > Probably we should be on-list. The branch is > scratch/icomplete-vertical-mode-gregory-and-joao and it's > functionally equivalent to Gregory's last on-list patch but a bit > simpler and cleaner on the implementation. Ergus discovered this new branch, so I tried it out. > C-n and C-p are supported, but indeed C-v and M-v are not. > It's a good idea to support them, yes. And maybe your idea is > the best way. Feel free to add a commit or two to that branch. > Else, let's just push this simpler version to master. If the basic functionally already works, then better to push the existing version to master.