From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.devel Subject: Re: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Sat, 08 May 2021 22:46:00 +0200 Message-ID: <87lf8prm2f.fsf@gmail.com> References: <87a6pcqy7s.fsf@red-bean.com> <83czu86o46.fsf@gnu.org> <835z006jpl.fsf@gnu.org> <87im3z3f8f.fsf@red-bean.com> <83zgxb67g2.fsf@gnu.org> <87mtt9sqh4.fsf@red-bean.com> <87czu58uso.fsf@gnus.org> <878s4tq8e6.fsf@red-bean.com> <874kfguail.fsf@red-bean.com> <875yzwtkuj.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33612"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Karl Fogel , Lars Ingebrigtsen , Stefan Monnier , "emacs-devel@gnu.org" To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 08 22:46:54 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfTqg-0008fh-1L for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 22:46:54 +0200 Original-Received: from localhost ([::1]:41704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfTqf-0002cg-4C for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 16:46:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfTpq-0001aR-PX for emacs-devel@gnu.org; Sat, 08 May 2021 16:46:02 -0400 Original-Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:45003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lfTpl-0001Mt-Hb for emacs-devel@gnu.org; Sat, 08 May 2021 16:46:02 -0400 Original-Received: by mail-wm1-x332.google.com with SMTP id 82-20020a1c01550000b0290142562ff7c9so6697875wmb.3 for ; Sat, 08 May 2021 13:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=klkahrcGB5ka0PL7GSIgpK2e6DmsZY0ziI9DSOINYLA=; b=chi+/tgMwklT8hmatvw7Hdyk4NKDh3iLZE9q6noERdQ642CSoZFGZFZzdFJLjNjzYA 1lq+mpgOjqj3pKP5XtfGWKuSFhxB2+L/NBRw+JrPPT+L1x8qR89lkPxJESUCobUiDYsR PVPVsEU7wTsrlBg2+keFPU3jbBALBoOKxD8aC3Jpkid2L27rN9V3xUaC5mcRBqhsCGM9 d70cen/UDO+KVy2i7PHO/nnNcN2ZbD2J9L8wXU8zRgDErtkEDh8F8UFPTVMNbDJfHqar 08y3qlNadyKmRngRuirXtPRfAFShooY6Croa5hqwF2cdUnvtwte1jjw2bC2cQ1/64dJT Yd8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=klkahrcGB5ka0PL7GSIgpK2e6DmsZY0ziI9DSOINYLA=; b=lG+z7vknwQ+cF5b+mFSfgLGXdO3Nq3FJiYA3KXj2Q8XyJHHBkxk2b3NrWeAqVFM1TI zmXKUgKF/qROEVCO/qds7G8pn70NYobX1u51VsgBLPGa6B4vyzaLRp/ciGxfyBopy1YT Q+O6Hus1dIL/U3E3VJ8p6RjRyuriRnk9ft0GLbm5Jg/KEsAMvqNE4wdFq4B2B9yP4M2W FE79aS03mb882yMI2XEY6pxbs1insrTiYRnGj0FSkoNDXt6sH1kePdKM+oErU/U5sNuq dqO+PCU0hpCmPf8L1O9zBk4hZVSxmUz5LYZYP8MASpxBpkvjnBLjyClOaD0FchI5zK6Z Itcg== X-Gm-Message-State: AOAM5327y4Sq4souJx0p68mIzWdy/dAOsC6iiA/yOM6i60zysg+RJ9nK IZzSsX7fwzFJHidiVkaHcOomLSR2ukNnzw== X-Google-Smtp-Source: ABdhPJw3dmIetg0pU29yAJt88oEl67UxhuAjREp+KUkGlE/dAJO2ngWZ1f2BdXotKZWvbkBvwAJQzQ== X-Received: by 2002:a1c:7e82:: with SMTP id z124mr28913609wmc.51.1620506756080; Sat, 08 May 2021 13:45:56 -0700 (PDT) Original-Received: from carbon.localdomain (44.107.204.77.rev.sfr.net. [77.204.107.44]) by smtp.gmail.com with ESMTPSA id c62sm901844wme.5.2021.05.08.13.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 May 2021 13:45:55 -0700 (PDT) In-Reply-To: (Drew Adams's message of "Thu, 6 May 2021 15:29:26 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=orontee@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269066 Archived-At: Drew Adams writes: > [IIRC, vanilla bookmark.el doesn't have a way to > switch to a different bookmark file interactively. > All it needs to do, to add that, is to let a prefix > arg for `bookmark-load' and `bookmark-bmenu-load' > provide non-nil arg OVERWRITE. It provides a > prefix arg for saving, but not for loading.] I checked the implementation of `bookmark-bmenu-load' and `bookmark-load' and learned that this is already implemented: One can C-u l from a bookmark menu buffer to load bookmarks destructively and change the path of the default bookmark file! Should the docstring of `bookmark-bmenu-load' should be extended as follows to make this feature easier to discover? diff --git a/lisp/bookmark.el b/lisp/bookmark.el index 64b467adfa..766ddc8402 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -2063,7 +2063,10 @@ bookmark-bmenu-save (defun bookmark-bmenu-load () - "Load the bookmark file and rebuild the bookmark menu-buffer." + "Load the bookmark file and rebuild the bookmark menu-buffer. +With a prefix arg, existing bookmarks are destroyed and the +loaded bookmark file is watched. +" (interactive nil bookmark-bmenu-mode) (bookmark-bmenu-ensure-position) (save-excursion -- Matthias