unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: emacs-devel@gnu.org
Cc: Luke Lee <luke.yx.lee@gmail.com>
Subject: Re: master 87e7390: * lisp/progmodes/hideif.el: update for new C++ standards and extensions
Date: Wed, 02 Jun 2021 16:19:06 +0100	[thread overview]
Message-ID: <87lf7sguqd.fsf@tcd.ie> (raw)
In-Reply-To: <20210602123047.2969E209AA@vcs0.savannah.gnu.org> (Luke Lee's message of "Wed, 2 Jun 2021 08:30:46 -0400 (EDT)")

luke.yx.lee@gmail.com (Luke Lee) writes:

> branch: master
> commit 87e7390aaef0978bdef6f3b73af43305fab7db21
> Author: Luke Lee <luke.yx.lee@gmail.com>
> Commit: Luke Lee <luke.yx.lee@gmail.com>
>
>     * lisp/progmodes/hideif.el: update for new C++ standards and extensions

[...]

> -(defcustom hide-ifdef-expand-reinclusion-protection t
> +(defcustom hide-ifdef-expand-reinclusion-guard t

Does this need a define-obsolete-variable-alias for backward
compatibility?

> +(defcustom hide-ifdef-verbose nil
> +  "Show some defining symbols on hiding for a visible feedback."
> +  :type 'boolean
> +  :version "27.2")
> +
> +(defcustom hide-ifdef-evalulate-enter-hook nil
> +  "Hook function to be called when entering `hif-evaluate-macro'."
> +  :type 'hook
> +  :version "27.2")
> +
> +(defcustom hide-ifdef-evalulate-leave-hook nil
> +  "Hook function to be called when leaving `hif-evaluate-macro'."
> +  :type 'hook
> +  :version "27.2")

Should these :versions be "28.1"?

Thanks,

-- 
Basil



       reply	other threads:[~2021-06-02 15:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210602123045.16251.72470@vcs0.savannah.gnu.org>
     [not found] ` <20210602123047.2969E209AA@vcs0.savannah.gnu.org>
2021-06-02 15:19   ` Basil L. Contovounesios [this message]
2021-06-03  2:50     ` master 87e7390: * lisp/progmodes/hideif.el: update for new C++ standards and extensions Zhiwei Chen
2021-06-03  3:38       ` Luke Lee
2021-06-03  6:40         ` Eli Zaretskii
2021-06-03  9:10           ` Luke Lee
2021-06-03 10:52             ` Eli Zaretskii
2021-06-03  3:19     ` Luke Lee
2021-06-03  6:31       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf7sguqd.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    --cc=luke.yx.lee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).