From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.devel Subject: Re: bug#49822: master e32c7d2: Change Python eval to send directly instead of using temporary files Date: Mon, 06 Sep 2021 18:08:43 +0200 Message-ID: <87lf49wut0.fsf@gmail.com> References: <20210903122828.16890.65271@vcs0.savannah.gnu.org> <20210903122829.EAAC220B71@vcs0.savannah.gnu.org> <87r1e4eklw.fsf@gmail.com> <87v93fnfmm.fsf@igel.home> <87lf4aooge.fsf@gmail.com> <878s0a409g.fsf@gmx.de> <87ilzef65i.fsf@igel.home> <878s0aeyna.fsf@gmx.de> <87r1e1ex7z.fsf@igel.home> <874kaxgbgs.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14910"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49822@debbugs.gnu.org, Lars Ingebrigtsen , Andreas Schwab , Stefan Monnier , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 06 18:10:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNHC5-0003fv-VC for ged-emacs-devel@m.gmane-mx.org; Mon, 06 Sep 2021 18:10:01 +0200 Original-Received: from localhost ([::1]:59818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNHC4-0007o0-IB for ged-emacs-devel@m.gmane-mx.org; Mon, 06 Sep 2021 12:10:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNHAv-0006hL-94 for emacs-devel@gnu.org; Mon, 06 Sep 2021 12:08:49 -0400 Original-Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]:44772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNHAs-0007Lv-Pr for emacs-devel@gnu.org; Mon, 06 Sep 2021 12:08:49 -0400 Original-Received: by mail-ej1-x62c.google.com with SMTP id me10so14342510ejb.11 for ; Mon, 06 Sep 2021 09:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qb2zpOFH322bxzLdOR8HoPi2ymosraMmBWfdiB2gGVc=; b=dkEQdsWQlwGkW2YhNkqz/zdKE2aqekAABY7C5sWqla6WURHPmOik8uA20ko+W4JSYH XX0oHZjfqKxT7SXX3kDvRCLL4CsaHrn1iaebSRCLlupdRRSsVCOtXFX3LDNtXVze0EpD jWnIrU5dvwiGzteZPU/ddbq613lHCTMMHY2zNpjUOX70OTQvnoHVjN6CnOKgbaW8zf00 169oaMl6iNz5iHBd87k1BG2hDXC5r9KSu/2HnzXBJCST0T5TWz5SI3UhaARu3w0Vbx0y 0C5Ox+XQMyrZS9XwOGqbdvzuM79wlzeQMMsNqJeNiyqOS1QCtzBFOf1DqubeImIXAViS OjMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qb2zpOFH322bxzLdOR8HoPi2ymosraMmBWfdiB2gGVc=; b=C2CFjMdui9kuP6Abwe+I5Hq9rVlQKMO8ceozx6YuJX2GWWKqMpMS1b/MaMod8aZO18 /zT5IEnZynCPh4LlaTZmDF0v/ZVuKZIIfyEhi/yO3C+A5boHDC5mmkp3rKbdiQ85fUHx GDxYlChMcI7249XGOKL3FLcg69zkdIEQpTbFFxOY77/Ru0pespmKjz3dBwkVeZa1IzTl vCkFLqipJ20B036ViHQLErKoQYrzDCWWq+1qiHWOqI/tUTy6Og0iz1uwdJ1W5CnUClvU ovxlVlgmSk8VXKHmGq3aO42zoMXztIhcsdNFYBrvwbf+bQlrUhU0kjvm+NdiaFmMxluT YwaQ== X-Gm-Message-State: AOAM532FwylinpdnFEProy86kkuNiu5y4YZuBfBYTh8bCoTiH4/GlfL2 3KTKMx/l8mN8lCTeMgBzqA0HfkKso76UBQ== X-Google-Smtp-Source: ABdhPJyje0Vol9NUfVQ7LWEx3duW4LGwcxSBwKDxrZ5yh2SaYF0aaZhzWK6W3zvaslQ4CPu7d4jphQ== X-Received: by 2002:a17:907:1c1f:: with SMTP id nc31mr14052901ejc.371.1630944524875; Mon, 06 Sep 2021 09:08:44 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::b1d]) by smtp.gmail.com with ESMTPSA id dy7sm4965868edb.38.2021.09.06.09.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Sep 2021 09:08:44 -0700 (PDT) In-Reply-To: <874kaxgbgs.fsf@gmx.de> (Michael Albinus's message of "Mon, 06 Sep 2021 14:00:51 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274145 Archived-At: On Mon, 6 Sep 2021 at 14:00, Michael Albinus wrote: > Andreas Schwab writes: > >> Neither has PIPE_BUF. > > Great that you always say what's not working. Perhaps you have a better > answer to Augusto? > >> Andreas. > > Best regards, Michael. Thanks for the ideas. If there's no simple and platform-independent way to obtain the line length limit in a PTY, then I think there's no reason to attempt anything fancy in python.el (or any derived comint mode, for that matter). So the options seem to be: either hard-code a limit of 1024 chars, or create a defcustom with a platform-dependent default. But such a defcustom should probably be part of comint.el, and should be added by someone who (unlike me) actually understands this stuff. Working around a limit of less than 1024 characters is too awkward, so I hope this is a safe assumption. The juggling of temp files that existed in python.el for many years already required lines of ~350 chars, depending on how the OS names temp files. Sorry for introducing a bug in master. I think I got it fixed here, and I'll submit the patch when I'm confident about it.