From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 5252c45: Initialise unread buffer Date: Sun, 19 Sep 2021 16:26:51 +0200 Message-ID: <87lf3spro4.fsf@gnus.org> References: <20210919142251.2698.98689@vcs0.savannah.gnu.org> <20210919142252.B0B1520ABE@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18295"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 19 16:27:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRxn7-0004Xl-Qz for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Sep 2021 16:27:37 +0200 Original-Received: from localhost ([::1]:33670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRxn6-0007ke-5P for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Sep 2021 10:27:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRxmX-00075O-Mi for emacs-devel@gnu.org; Sun, 19 Sep 2021 10:27:01 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:58992) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRxmW-0003o5-7X for emacs-devel@gnu.org; Sun, 19 Sep 2021 10:27:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lky1zl/gx9Tn1r3C8YsXjZ+c8mZnkcja2xgeR1Huo34=; b=N/stIwd/ipCrRlI7zdw3MwbuXM 0406aL5aZY9pIJo1sALWN58DmwR1+75K6zAxN/xSi+KLb0jahkS5oW92LXaFCFuloyEJvvYmiQnDl 4hin6HrjI1t8ZgzWDp5tAFiFidjnktxRnapO70puQNG43jozxSi3cfAAgAH1eQS7FUUA=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRxmP-0007GP-Kg; Sun, 19 Sep 2021 16:26:56 +0200 In-Reply-To: <20210919142252.B0B1520ABE@vcs0.savannah.gnu.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sun, 19 Sep 2021 10:22:52 -0400 (EDT)") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275053 Archived-At: Mattias Engdeg=C3=A5rd writes: > The reader has an extra 1-char unread buffer that was incorrectly > initialised to 0, which means that the first character read would > always be NUL. As this is often the code that looks for the > lexical-binding cookie, the first loaded source module would be > treated as dynamically bound. During bootstrapping this is loadup.el > and so its local variables got dumped into the global environment. Wow. How did you manage to debug this? :-) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no