From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: tab-bar-switch-to-tab removes custom tab data? Date: Mon, 20 Sep 2021 18:28:47 +0300 Organization: LINKOV.NET Message-ID: <87lf3rpghc.fsf@mail.linkov.net> References: <8735q089zg.fsf@alphapapa.net> <871r5jpxed.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23236"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 20 17:35:39 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSLKV-0005pv-RB for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 17:35:39 +0200 Original-Received: from localhost ([::1]:37790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSLKT-0002qR-UV for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 11:35:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSLE5-0001G6-L7 for emacs-devel@gnu.org; Mon, 20 Sep 2021 11:29:01 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:44695) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSLE3-0008Ae-3t for emacs-devel@gnu.org; Mon, 20 Sep 2021 11:29:01 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 2E0D96000A; Mon, 20 Sep 2021 15:28:54 +0000 (UTC) In-Reply-To: <871r5jpxed.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 20 Sep 2021 09:45:22 +0300") Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275144 Archived-At: --=-=-= Content-Type: text/plain >> I'm not sure if this is intended, or if what I'm doing is allowed, but I >> noticed that after I add an association to the current tab and then use >> tab-switch twice, to change tab and then change back, the association I >> added is gone. > > So you want to add more metadata to a tab? > Once in the past I proposed such a feature, > but no one needed it :) Now this could be added. Here is a patch that implements this, but it's still 100% untested, so use it at your own risk :) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=custom-tab-data.patch diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index c19b754543..7f9b56c7d2 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -931,7 +931,15 @@ tab-bar--tab (wc-bl . ,bl) (wc-bbl . ,bbl) (wc-history-back . ,(gethash (or frame (selected-frame)) tab-bar-history-back)) - (wc-history-forward . ,(gethash (or frame (selected-frame)) tab-bar-history-forward))))) + (wc-history-forward . ,(gethash (or frame (selected-frame)) tab-bar-history-forward)) + ;; Copy other possible parameters + ,@(mapcan (lambda (param) + (unless (memq (car param) + '(name explicit-name group time + ws wc wc-point wc-bl wc-bbl + wc-history-back wc-history-forward)) + (list param))) + (cdr tab))))) (defun tab-bar--current-tab (&optional tab frame) (tab-bar--current-tab-make (or tab (tab-bar--current-tab-find nil frame)))) @@ -951,7 +959,15 @@ tab-bar--current-tab-make (alist-get 'name tab) (funcall tab-bar-tab-name-function))) (explicit-name . ,tab-explicit-name) - ,@(if tab-group `((group . ,tab-group)))))) + ,@(if tab-group `((group . ,tab-group))) + ;; Copy other possible parameters + ,@(mapcan (lambda (param) + (unless (memq (car param) + '(name explicit-name group time + ws wc wc-point wc-bl wc-bbl + wc-history-back wc-history-forward)) + (list param))) + (cdr tab))))) (defun tab-bar--current-tab-find (&optional tabs frame) (assq 'current-tab (or tabs (funcall tab-bar-tabs-function frame)))) --=-=-=--