From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Patch proposal: display symbol source code in help buffers Date: Fri, 01 Oct 2021 17:08:14 +0800 Message-ID: <87lf3dcdtt.fsf@localhost> References: <875yuvlrz3.fsf@gnus.org> <87r1djixiw.fsf@gnus.org> <878rzrzpfz.fsf@localhost> <87zgs7y5wc.fsf@localhost> <87sfxyftrw.fsf@gnus.org> <87mto6ifd2.fsf@localhost> <83r1diz5k9.fsf@gnu.org> <87r1diqodc.fsf@localhost> <87ee9h27rm.fsf@gnus.org> <87wnmxcjhm.fsf@localhost> <8335plfbs7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23801"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, stefankangas@gmail.com, arthur.miller@live.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 01 11:09:26 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWEXl-00063p-Rq for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Oct 2021 11:09:25 +0200 Original-Received: from localhost ([::1]:45570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWEXk-00059u-P6 for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Oct 2021 05:09:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWEVQ-0000VJ-Pn for emacs-devel@gnu.org; Fri, 01 Oct 2021 05:07:00 -0400 Original-Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]:38848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWEVP-0001I6-CR; Fri, 01 Oct 2021 05:07:00 -0400 Original-Received: by mail-pf1-x433.google.com with SMTP id k26so7357311pfi.5; Fri, 01 Oct 2021 02:06:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=rTAGjyKamIIClgkcrX9PtmSCd/tgDipdSB8OVL+PRmM=; b=gOg9KSyvnVp8PfX4YHN+R5kBMzNGh1ieLD3s9PkNGAb5Q+SBCUTyy11gfwLGns8kLr iy+5DCZ6kI24RlpKNb+wg5f9TLMjbLdSzS7KCX6+50mJXWGbCL9J9s0cjx+R8U0IonvV Gpmr8feE3A9E/h5Nm8AJCXiUFz87KQ3DZIm0XjpuQTJZ0TVnd5gGfUSpQTdsLSHKzG5V iWvkMHo79c/R5kyND2C0Fx4hyrEI17D+YI/yCscdFlhrNYu6JxA4baTJdzTZPd6ob4xI v17wTQOp1LMYNY6QBRTVChHuSnyPcIjnwUsYRWe4iRj/oXhiYrlJLtFG1P1xrTcmg9QT HW4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=rTAGjyKamIIClgkcrX9PtmSCd/tgDipdSB8OVL+PRmM=; b=IdHumspSaqzidLdM4MiAT6ot9X8DNAyIt7oYEwYj9LrYyun8mmJqLfAKlxtTk3cH4J OErvJzJ+Fs/rqgnXpLxxTP0zOLUPBIdnCW+iWC957q6Ll0LKf21Kuj6R3HRf3/9vperM uASZ6DhO+VS7YdzRXerVubj8WA7+naNs12MqEyoKvSsaoGxNLiJEcWYIDO+Fxz/WsjIZ NbtlefIBc5LMP3IL0G/6PVqhA0MWCTZMe6mblhwUqdaEXp0TATstIVfRptpPPhy0opxc ovAKibt8ILpdQcmK53D2md2o1OtUb6Av63Z/CioSJe74YOqxKK+4uP2+037dgX7xmu8J dPsQ== X-Gm-Message-State: AOAM531US7hQuVT8f8bpR5GYz0YZn6UIzX9PdNmzGVxnI92LHSeyc/H4 Sf9SVSHb6bclcjB5HyEbGsQKc8MK8CIC1YJLvAw= X-Google-Smtp-Source: ABdhPJyJyDKcvSwbvE00aamr1XUWcHIX25NA4YfYeMWujE8Z2MCt7+h8ZLwmLndTwCLdTUOyi0dmXA== X-Received: by 2002:a63:2361:: with SMTP id u33mr6723639pgm.369.1633079216942; Fri, 01 Oct 2021 02:06:56 -0700 (PDT) Original-Received: from localhost ([210.3.160.230]) by smtp.gmail.com with ESMTPSA id t3sm5685233pgo.51.2021.10.01.02.06.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Oct 2021 02:06:56 -0700 (PDT) In-Reply-To: <8335plfbs7.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::433; envelope-from=yantar92@gmail.com; helo=mail-pf1-x433.google.com X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275969 Archived-At: Eli Zaretskii writes: >> From: Ihor Radchenko >> Cc: Eli Zaretskii , Stefan Kangas , >> arthur.miller@live.com, emacs-devel@gnu.org >> Date: Fri, 01 Oct 2021 15:05:57 +0800 >> >> + ;; Save mark for the old location, unless we just opened >> + ;; the buffer or the point is not actually going to move. >> + (unless (or (= 1 (point)) >> + (= (point) position)) >> + (push-mark nil t)) > > This assumes that if point is at BOB, we "just opened the buffer"? > What if the user moves point, then returns to BOB? Lars applied the patch without (= 1...) clause, so it does not matter anymore. > And why do you use 1 instead of point-min? Mostly because I prefer to state it explicitly to not confuse BOB with beginning of a narrow. Is there any scenario when BOB is not at 1? Best, Ihor