From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: GStreamer xwidget Date: Fri, 19 Nov 2021 06:38:49 +0100 Message-ID: <87lf1kyaae.fsf@gnus.org> References: <87ee7cq2mu.fsf.ref@yahoo.com> <87ee7cq2mu.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36382"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 19 06:39:45 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnwci-0009Hr-6e for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Nov 2021 06:39:44 +0100 Original-Received: from localhost ([::1]:57562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnwch-0001Ub-5g for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Nov 2021 00:39:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnwbx-0000pQ-HS for emacs-devel@gnu.org; Fri, 19 Nov 2021 00:38:57 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=46098 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnwbv-0003kc-Kl for emacs-devel@gnu.org; Fri, 19 Nov 2021 00:38:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yqckqh8M8YM/eDpygYo30LX/R+BNIiTIHgZZnQWR4eY=; b=BZtrVaQeuom8D+BEDIbrf1HI9U XcohxwmQvNkkFiIccyGD8TEjAh32ZqmnbaGdgLm5+kc65DEcEb9g3vIJWO0JFDW3XZQOC27vGvBu1 j7YQ280HVS4mhFUSi8/jaS8UvpyarHUKbqkWeavKamT44X7azJSHKIz+uBmeZetsN62M=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnwbp-0007S2-NB; Fri, 19 Nov 2021 06:38:53 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXNy7idjXWOc1xO TEX///914w1+AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+ULEwUZLv48j80AAAG5SURBVDjLbZSLlcQg CEVFGxBtQLABlf57W0DNZmbX44lO7vDxCQnh/4G/WyiM+S+ALjZW/gIgd+QH+E7ki0AA0CVJIZsi vOgAm5lrWqJTyqQKB+iYvcCUqBZZZk9v0JK4xQQF44I2+0iyIjNLo5rkABhqEYUjYuGFCsYGacyK +ndAHeUFeIxS9a2lDqiuZtvpCi31oEBPi0il0CQFmOy4TFckKKratF017Z73JhNjt9VkdcGBnWI/ grknPAK7L13H+U24XZrzT5DNkqqbWPQVQvTYpvw0OE6QA9xTs8d8QDnAvSR7epAvEC1RB9mBZeun BeG2QdvAkrLrCUzjAt4Atj4q4j3IA8yCKOM+yAtQ8Tp7wAkOUqdrWN5A042rwwHwCWYPb9CuJIX4 VvM54BHxLziysye1y5xdKwecudXnzre64V8wbzEEaTVb9eWt94BTPiDNizy0DRr45Wj1CyUzjw2y 3xPs6BQVWDHVrHVttQA7ei6dium7VHg0QWDXKJa+0FIhBdry2ftcm0nbYjUFgFmljOt8ABQw8i+w nL0H0wJtPzwAX5+MBn0Rdo2RP4FJTOC1n3E3Q/kBONRhSgbGTwQAAAAldEVYdGRhdGU6Y3JlYXRl ADIwMjEtMTEtMTlUMDU6MjU6NDYrMDA6MDC3HIbnAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTEx LTE5VDA1OjI1OjQ2KzAwOjAwxkE+WwAAAABJRU5ErkJggg== X-Now-Playing: Judee Sill's _Abracadabra: The Asylum Years (1)_: "Ridge Rider" In-Reply-To: <87ee7cq2mu.fsf@yahoo.com> (Po Lu's message of "Fri, 19 Nov 2021 10:51:21 +0800") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279708 Archived-At: Po Lu writes: > Right now, it can only display a test pattern, but getting that to work > and perform decently was a challenge (for instance, offscreen rendering > is not an option, Hm... isn't the webkit rendering done offscreen? And that's able to play videos just fine? > instead the pipeline is dynamically built based on > available xwidget views, utilizing hardware acceleration and video > decoding if available). > > WDYT? Sounds good to me. Do you have a code snippet that will display one of these widgets? Then I can test the patch here. Skimming the patch, it looks good to me. The one extremely minor nit I have is this superfluous {}: > +#ifdef HAVE_GSTREAMER > + if (EQ (xw->type, Qmedia)) > + { > + XResizeWindow (xv->dpy, xv->internal_window, > + xw->width, xw->height); > + } -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no