unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Matt Armstrong <matt@rfc20.org>
To: Qiantan Hong <qhong@mit.edu>,
	"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Cc: Michael Albinus <michael.albinus@gmx.de>
Subject: Re: Question: suppress ask-user-about-lock?
Date: Wed, 08 Dec 2021 14:03:29 -0800	[thread overview]
Message-ID: <87lf0uoitq.fsf@rfc20.org> (raw)
In-Reply-To: <F6D92664-F794-4D0F-8212-8C3CA5432B64@mit.edu>

Qiantan Hong <qhong@mit.edu> writes:

>> What about (untested)
>> 
>> (cl-letf (((symbol-function #'ask-user-about-lock)
>>           (lambda (file proponent)
>>             (signal 'file-locked (list file proponent)))))
>> 
>> ...)
>
> I guess it will break under multi-thread environment?  Because FLET,
> or function cells in general, are not thread local.

(info "(elisp)Threads") talks about `let' bindings being thread local.
I always took that to apply to the other let-like bindings as well.  It
looks like `cl-letf' uses `let*' under the hood.


> I also feel like the above is as hacky as my (let ((noninteractive t))
> (lock-buffer)) Does anyone have more recommendations?

It think it feels hacky because `ask-user-about-lock' is a decades old
API and was probably introduced before the abnormal hook convention took
hold (info "(elisp)Standard Hooks").  I suspect that back then
redefining functions as a customization point was more common.

If the API were added today I think you'd see an
`ask-user-about-lock-function' (or functions) var that is bound to
#'ask-user-about-lock by default.  The Emacs C layer would then funcall
it.



  parent reply	other threads:[~2021-12-08 22:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-08 17:34 Question: suppress ask-user-about-lock? Qiantan Hong
2021-12-08 19:17 ` Michael Albinus
2021-12-08 19:22   ` Qiantan Hong
2021-12-08 19:36     ` Michael Albinus
2021-12-08 19:43       ` Qiantan Hong
2021-12-08 20:12         ` Michael Albinus
2021-12-08 22:03         ` Matt Armstrong [this message]
2021-12-08 22:12           ` Qiantan Hong
2021-12-08 20:03     ` Eli Zaretskii
2021-12-08 20:12       ` Qiantan Hong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf0uoitq.fsf@rfc20.org \
    --to=matt@rfc20.org \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=qhong@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).