From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Sv: Sv: Support for background transparency Date: Mon, 24 Jan 2022 10:14:52 +0100 Message-ID: <87lez5jy0j.fsf@gmail.com> References: <87wnlnptf2.fsf@gnus.org> <83h7bwybeg.fsf@gnu.org> <87y24t1ed1.fsf@gnus.org> <87k0eulqhx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24636"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: =?utf-8?Q?H=C3=A5kon?= Flatval Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 24 10:17:42 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBvTp-0006Hh-Lc for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Jan 2022 10:17:41 +0100 Original-Received: from localhost ([::1]:53158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBvTo-0004nz-HQ for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Jan 2022 04:17:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBvRC-0003Gh-Q2 for emacs-devel@gnu.org; Mon, 24 Jan 2022 04:14:58 -0500 Original-Received: from [2a00:1450:4864:20::42c] (port=39686 helo=mail-wr1-x42c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nBvRB-0004nN-7t for emacs-devel@gnu.org; Mon, 24 Jan 2022 04:14:58 -0500 Original-Received: by mail-wr1-x42c.google.com with SMTP id r14so1681261wrc.6 for ; Mon, 24 Jan 2022 01:14:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=YNNW37Bt3vWhW1Sx9GKdmq68WYiUINmTJyPSIc03UvY=; b=YFKegAiH3B20BurweMWLYi3To083sCSV28mwyWclrDDfmzel0qMMBcMsdwo6gvtc2G re9gO46QHGlUwgPMuwesKkmA1wy/HFYfc9rXowszqvGqAnQ35G3dsSm57fUUj30NU/g8 SC69rW68LiCQf6lSC5kw4rtULO6Naoauh2FsYE0lQD+mg4DvmWYiQYqwvkuVwVQ4rsJJ Z02KOlv7bS6uWPgp1m+i/IPdqxDwVvKFqNbvtAtFv8CDIL4mqW7yHJEjdPqxNP2/sdI4 vo8GEJuCTPVzuU0SljPkCbYyG0Q2IvnacKL6QbHwHpNHRxo/IoQyRyA2WY8okrwwj6Q5 lNnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=YNNW37Bt3vWhW1Sx9GKdmq68WYiUINmTJyPSIc03UvY=; b=4DgmIRbrska9LLxqW1syh18EcnYbiKA2A7PPmQtXZ/9TR+gANby37ppuPZa7WPG9bn BfNmQYUeBif32Vt4Tvx7voMw/jkQVEdNK200/DTE5ze0pt/QEMrae+OWVtqYcJrQxDrQ EGPnfVCgacRsAV3T0SF/WJaE5MTYHfOF3Xiyw1Ck6zEqSQSMQSAx5V39Gm0zx4PAkW4J MkGyd/7kUF46vI9bJULgeNXf8YTqlc5Psl+ZRfCcGuHcacJYOGjbWCXfBH3ij/hY5Vu9 o+1HxcxFnI6F7zj7y8wZ3CWevaJNPad7ka7l0uhiFVBGf1BLjO9IW5AjQaF/GdVGugQN uzeQ== X-Gm-Message-State: AOAM530u04bl7f95e5C/6C1AcGQ7CVhtVClYRj/6UmFt+1MeeHdQ5F1i nyejKOT8gOkQCsj0kezPhSRzFB2OPE0= X-Google-Smtp-Source: ABdhPJwZK04AMGQNyKrrdRC6jGzDRPLB5xiaKFcDjwQs18OA6KpUPFBX1YUh3Dei2moQGm32uphixQ== X-Received: by 2002:adf:fac9:: with SMTP id a9mr13041713wrs.318.1643015693924; Mon, 24 Jan 2022 01:14:53 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:a941:80ce:6692:e00b]) by smtp.gmail.com with ESMTPSA id l10sm3553061wry.67.2022.01.24.01.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 01:14:53 -0800 (PST) In-Reply-To: (=?utf-8?Q?=22H=C3=A5kon?= Flatval"'s message of "Sun, 23 Jan 2022 22:43:04 +0100") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42c (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=rpluim@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285288 Archived-At: >>>>> On Sun, 23 Jan 2022 22:43:04 +0100, H=C3=A5kon Flatval said: >> - Something answering the question: "what's the difference between >> this and the existing 'alpha frame parameter", H=C3=A5kon> I added paragraph after that for alpha with a brief descrip= tion. H=C3=A5kon> I have included it in the attached patch. For convenience, = I'm H=C3=A5kon> reciting the relevant part here: H=C3=A5kon> =3D=3D=3D=3D H=C3=A5kon> diff --git a/doc/lispref/frames.texi b/doc/lispref/frame= s.texi H=C3=A5kon> index 2eeb8b7ed7..05d0b1a72a 100644 H=C3=A5kon> --- a/doc/lispref/frames.texi H=C3=A5kon> +++ b/doc/lispref/frames.texi H=C3=A5kon> @@ -2433,6 +2433,16 @@ Font and Color Parameters H=C3=A5kon> Some window systems do not support the @code{alpha} par= ameter for child H=C3=A5kon> frames (@pxref{Child Frames}). H=C3=A5kon> + H=C3=A5kon> +@vindex alpha-background@r{, a frame parameter} H=C3=A5kon> +@item alpha-background H=C3=A5kon> +@cindex opacity, frame H=C3=A5kon> +@cindex transparency, frame H=C3=A5kon> +Sets the background transparency of the frame. Unlike t= he @code{alpha} H=C3=A5kon> +frame parameter, this only controls the transparency of= the background H=C3=A5kon> +while keeping foreground elements such as text fully op= aque. H=C3=A5kon> +It should be an integer between 0 and 100, where 0 means H=C3=A5kon> +completely transparent and 100 means completely opaque = (default). H=C3=A5kon> @end table H=C3=A5kon> The following frame parameters are semi-obsolete in tha= t they are H=C3=A5kon> =3D=3D=3D=3D H=C3=A5kon> Please let me know if this is what you had in mind or if I = should revise H=C3=A5kon> it. That looks good, although the Emacs convention is to put two spaces after '.' >> - a commit message containing a description of the changes in >> ChangeLog format H=C3=A5kon> I have attached a file with a changelog entry. I'm also giv= ing it here H=C3=A5kon> for convenience: H=C3=A5kon> =3D=3D=3D=3D H=C3=A5kon> 2022-01-23 H=C3=A5kon Flatval H=C3=A5kon> Add support for background transparency H=C3=A5kon> * src/haikufns.c: H=C3=A5kon> * src/nsfns.m: H=C3=A5kon> * src/pgtkfns.c: H=C3=A5kon> * src/w32fns.c: H=C3=A5kon> * src/xfns.c: Add alpha-background frame parameter defa= ults. Prefer to use 32-bit depth visual in X. H=C3=A5kon> * src/frame.h: H=C3=A5kon> * src/frame.c: Add alpha-background frame parameter and= setter function. H=C3=A5kon> * src/gtkutil.c: Setup GTK to allow transparency. H=C3=A5kon> * src/xterm.c: Draw background transparent using alpha-= background frame parameter. H=C3=A5kon> * doc/lispref/frames.texi: Add docs for alpha-backgroun= d frame parameter H=C3=A5kon> =3D=3D=3D=3D H=C3=A5kon> Let me know if it needs changes. Each filename should also have the name of the affected function in parens after it (before the ':'). C-x 4 a when in a diff will fill in this kind of stuff for you automatically (or 'magit-generate-changelog' if you use magit to commit). H=C3=A5kon> I'm a little confused as to where I should put this. Should= I add it to H=C3=A5kon> one of the Changelog files? It goes in the commit message when you commit locally using git. See CONTRIBUTE in the emacs repository (search for "** Commit messages") Committing locally has the additional advantage that you can later do "git format-patch" to produce a patch file, which is easy for the maintainers to apply (and preserves your commit message and authorship info). Robert --=20