eshell/addpath broken since commit dea24a0f7d

eshell/addpath broken since commit dea24a0f7d

[Iñigo Serna]

Hi

It looks `eshell/addpath' is broken in master since commit 
dea24a0f7d [1].

$ src/emacs --debug-init -Q --eval "(progn (require 'eshell) 
(eshell/addpath \"~/bin\"))"

Debugger entered--Lisp error: (wrong-number-of-arguments (4 . 4) 
3)
  eshell--do-opts("addpath" ((98 "begin" nil prepend "add path 
  element at beginning") (104 "help" nil nil "display this usage 
  message") :usage "[-b] PATH\nAdds the given PATH to $PATH.") 
  ("~/bin"))
  eshell/addpath("~/bin")


Thanks,
-- 
Iñigo Serna


[1]
commit dea24a0f7d4ae42fae912dd724a770678054989a
Author: Jim Porter <jporterbugs@gmail.com>
Date:   Mon Jan 24 21:03:42 2022 -0800

    Don't manipulate args in-place for 'eshell-eval-using-options'
    
    This is necessary for preserve the original arguments to 
    forward on to
    :external commands.  Previously, when :preserve-args was also 
    set, the
    original argument list could be altered, changing the meaning 
    of the
    command.

Re: eshell/addpath broken since commit dea24a0f7d

[Jim Porter]

On 1/25/2022 10:49 AM, Iñigo Serna wrote:
> It looks `eshell/addpath' is broken in master since commit dea24a0f7d [1].
> 
> $ src/emacs --debug-init -Q --eval "(progn (require 'eshell) 
> (eshell/addpath \"~/bin\"))"
> 
> Debugger entered--Lisp error: (wrong-number-of-arguments (4 . 4) 3)
>   eshell--do-opts("addpath" ((98 "begin" nil prepend "add path  element 
> at beginning") (104 "help" nil nil "display this usage  message") :usage 
> "[-b] PATH\nAdds the given PATH to $PATH.")  ("~/bin"))
>   eshell/addpath("~/bin")

Have you tried `make bootstrap' (or `touch lisp/eshell/*.el' if you 
don't want to rebuild everything)? Commit dea24a0f7d changes the 
`eshell-eval-using-options' macro in a way that requires recompiling 
files that use it.

- Jim

Re: eshell/addpath broken since commit dea24a0f7d

[Iñigo Serna]

Hi Jim,

> Have you tried `make bootstrap' (or `touch lisp/eshell/*.el' if 
> you
> don't want to rebuild everything)? Commit dea24a0f7d changes the
> `eshell-eval-using-options' macro in a way that requires 
> recompiling
> files that use it.

Ouch. You're right, I missed this part.
Sorry everyone for the noise.

Thanks,
-- 
Iñigo Serna

On 25 January 2022 at 20:19 +01, Jim Porter 
<jporterbugs@gmail.com> wrote:

> On 1/25/2022 10:49 AM, Iñigo Serna wrote:
>> It looks `eshell/addpath' is broken in master since commit 
>> dea24a0f7d [1].
>> $ src/emacs --debug-init -Q --eval "(progn (require 'eshell)
>> (eshell/addpath \"~/bin\"))"
>> Debugger entered--Lisp error: (wrong-number-of-arguments (4 
>> . 4) 3)
>>   eshell--do-opts("addpath" ((98 "begin" nil prepend "add path
>>  element at beginning") (104 "help" nil nil "display this usage
>>  message") :usage "[-b] PATH\nAdds the given PATH to $PATH.")
>>  ("~/bin"))
>>   eshell/addpath("~/bin")
>
> Have you tried `make bootstrap' (or `touch lisp/eshell/*.el' if 
> you
> don't want to rebuild everything)? Commit dea24a0f7d changes the
> `eshell-eval-using-options' macro in a way that requires 
> recompiling
> files that use it.
>
> - Jim