Re: master 4df7bb9c01 2/2: Fix display of stretch glyphs when hscrolled on PGTK

Re: master 4df7bb9c01 2/2: Fix display of stretch glyphs when hscrolled on PGTK

[Eli Zaretskii]

The resulting code after this changeset seems to test some conditions
twice:

>        if (x < text_left_x && !s->row->mode_line_p)
>  	{
> -	  int left_x = WINDOW_LEFT_SCROLL_BAR_AREA_WIDTH (s->w);
> -	  int right_x = text_left_x;
> +	  int background_width = s->background_width;
> +	  int x = s->x, text_left_x = window_box_left (s->w, TEXT_AREA);
>  
> -	  if (WINDOW_HAS_FRINGES_OUTSIDE_MARGINS (s->w))
> -	    left_x += WINDOW_LEFT_FRINGE_WIDTH (s->w);
> -	  else
> -	    right_x -= WINDOW_LEFT_FRINGE_WIDTH (s->w);
> -
> -	  /* Adjust X and BACKGROUND_WIDTH to fit inside the space
> -	     between LEFT_X and RIGHT_X.  */
> -	  if (x < left_x)
> +	  /* Don't draw into left fringe or scrollbar area except for
> +	     header line and mode line.  */
> +	  if (s->area == TEXT_AREA
> +	      && x < text_left_x && !s->row->mode_line_p)
>  	    {

The 'if (x < text_left_x && !s->row->mode_line_p)' condition is tested
again inside the block conditioned on that.  Is that necessary?

Re: master 4df7bb9c01 2/2: Fix display of stretch glyphs when hscrolled on PGTK

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> The 'if (x < text_left_x && !s->row->mode_line_p)' condition is tested
> again inside the block conditioned on that.  Is that necessary?

Thanks for catching that, it will be fixed shortly.