From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too Date: Mon, 11 Apr 2022 21:12:09 +0800 Message-ID: <87lewb228m.fsf@yahoo.com> References: <164967696186.12152.11548736665906939483@vcs2.savannah.gnu.org> <20220411113602.7A114C0581E@vcs2.savannah.gnu.org> <87bkx73jfz.fsf@yahoo.com> <878rsbbxi0.fsf@gnus.org> <874k2z3hj8.fsf@yahoo.com> <8735ijbwk7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31779"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 11 15:19:08 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndtwi-00083C-HK for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 15:19:08 +0200 Original-Received: from localhost ([::1]:59006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndtwh-0001BD-GH for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 09:19:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndtqJ-00032g-9n for emacs-devel@gnu.org; Mon, 11 Apr 2022 09:12:32 -0400 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:39408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ndtqH-0005Ts-6B for emacs-devel@gnu.org; Mon, 11 Apr 2022 09:12:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649682737; bh=kWtPPoo369XuegewzFhIiAdcsRSxVGGXUEbkYhP9txY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=TCCovW9YfLIexjtqfSKCcEOxJmyQBUZyXxqty72ATDvXmK9eQNirYm6jCX/jGlnaxloAm6/ebB4fzXWwyoAClbx/WpydQKYyMOYrzu4IwNZlu0yCQFpMKkhE5OE8xaMmQxd7vDLSsMQbTb34WDoyQK9XDS8IjzE/y+/3w0DJe94hw/x3JJyjmrWfUHtVsNv7OM0JWHS1GDtR4HOOBRvcn1GuzyclFl13xrVv0VjWBEPpwPXEHDz1DKFs1+nhuuUSTlBB0AgMzJU6L2opjVRZfX4WVejqmbksrP8woGYkiIkCOQ/hfJeZYrGPjfgtmUzDDX2jxLiMnWNgxtq9qjnaCQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649682737; bh=qLRkaZBfKmiZZzqWqjj2ipG1sIfQpKwjaAi2K2rd2pZ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=MvslV8kimYypGnONcoRhYxzHAjPhGXWXdbMUl7kiCdtViPJ84KJ9SWGMGsKJ/WqjrEet7hEZoRcn/VtpRxj9b9xvrV0t3yECBamZzQ7HrURRYKiHKJnf3fdWJpwkBCMhjV68qNx2kMmODD3FyiXpp+CEzkxPzH4UYF4M0Pocqmq9dG+T/ZxnwEJ+jdHF2YEC+HoFEHDE+dZQjCboH6NHOTJl0CfRsJSbeG3BkWNHkvU4Ek1W5u3jlRKzHXtZ+9aPmUTTmaGNecPXKrgwtQ2Zp6ZiLNLvqKCoSda8x4zduWXcd5ehXye8Eieo9b5HfuSBMWE2l7oberITSiUKM8C7Gg== X-YMail-OSG: ZOtAiioVM1mmfyJ.97HA_gEMoJOgnRJvUvaSWpEdt8Pm42LelYA83DhfwTJw9Wt T2M2bcCsjA92jMd8jyGbpVaYSLAUT73YEHEWgcr8mC0o80BumOISNr81zqr6nRsnUPpBmXc0_EDY zc.YQFmRPIiJ6dxe0.7gG7hp6uT4dBol7egiiriSq7ksVcgpHy4_5_PhP4iqqA8.WFMyMaOTCk5u cMEqOf6rcBMX8EJ4w8Ntdb.GURa8rW8sdKa2VjBRXEyCqTTvZbjCGef00OemwVMoXKw5_hkQu727 xRPZlToOrgH6DAYUK3YeLaIXmg1QuX3zWqTJIRmdFAALLvtdO80ninnH9G2ptAMlsk9sXRObeelw sKGC6KVw17j_tJC86Bs8XhCCFs4R3lYvs45Q45Laz9E44u0APtOluWJA9_eeeEOIHuJqVhnGSdYR gSpezNE.Fq8sut4r8rD33kvQzqHqDJamZaw.IrUXVGJLQWryLp.WJRYmy.4dvn2F.5HG6H3rS3jW TcLoG5zAcPrvNCG0IrrlHJbgp9.26jAr9xDpc7fjFECjvm8te5dPW5Cds2cpx0_NjX6Zm7881pcy DbyTWDJrOUTeqht_GGpomGnCQLDGOY1huIXTgjPdlqg5CYN0nbTlXeNDIhZHLjOhZTriXpguWLyL IE.JAyLnYqHOAy6rvEdD7rrxc1nwoDhCKuA4XOnPyx7H3S5iAMgN2JiVMef0boEbOhkqt.cajXzr iJmhSO4tFhOe9QrGkaczrzL0DG3Dvmh6tgt1hdwCYNxhcmbeyA.9.v6Wj1ZBPsYZZXmiOVZum8vq N30mhwx1L0Jd9eGwLAbfbGhkKkMTYEamkwKLPk3d8Z X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Mon, 11 Apr 2022 13:12:17 +0000 Original-Received: by hermes--canary-production-sg3-65d7bd97b5-rvrjv (VZM Hermes SMTP Server) with ESMTPA ID efb16b09b79f91b2969dce87c3573789; Mon, 11 Apr 2022 13:12:13 +0000 (UTC) In-Reply-To: <8735ijbwk7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 11 Apr 2022 15:04:40 +0200") X-Mailer: WebService/1.1.20048 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.31; envelope-from=luangruo@yahoo.com; helo=sonic307-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288190 Archived-At: Lars Ingebrigtsen writes: > For the imagemagick cache, we're just using a cookie, that's basically > what we're doing here, too. Perhaps sxhashing the spec and using that > instead would be fine, but it's slower, and we don't really care that > much about correctness here -- we're just using this to speed things up, > after all. Why not put something like this inside mark_image_cache? #if defined HAVE_WEBP || defined HAVE_GIF for (struct anim_cache *cache = anim_cache; cache; cache = cache->next) mark_object (cache->spec); #endif