From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master f2d2fe6fc8: server-execute: Initialize the *scratch* buffer Date: Tue, 03 May 2022 22:40:22 -0700 Message-ID: <87levhdfeh.fsf@athena.silentflame.com> References: <165162665935.26821.8964921720746152690@vcs2.savannah.gnu.org> <20220504011059.9F667C009A8@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16835"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.35 Emacs/29.0.50 (x86_64-pc-linux-gnu) To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 04 07:45:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nm7pa-00048P-GJ for ged-emacs-devel@m.gmane-mx.org; Wed, 04 May 2022 07:45:47 +0200 Original-Received: from localhost ([::1]:44582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nm7pZ-0001uk-0L for ged-emacs-devel@m.gmane-mx.org; Wed, 04 May 2022 01:45:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nm7kk-0000Zz-9Y for emacs-devel@gnu.org; Wed, 04 May 2022 01:40:47 -0400 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:53243) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nm7kh-0000m5-Ji for emacs-devel@gnu.org; Wed, 04 May 2022 01:40:45 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 9E2CA32001FF; Wed, 4 May 2022 01:40:24 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 04 May 2022 01:40:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1651642824; x=1651729224; bh=e5z5SM6TeY reZEPQ1B3ojgUW3mglm9vAFtcWNVL9NFE=; b=XCbypl2EeXi+fkkI6TxSf97ZDN j6qmBKKQIvWiYL+K0BH0W+nb0SOTxahoScq52btJxth2zwYDwRcF7OqDphmbR10s 4dZ1vTELuiQJH3C8U5jrRtPZJaQ4ECYRqv1hX+GjdCJAnVgJdYFdW6IEUyDwlwaw TNDC5n9FWxf7NU5Nqe9NX3lTFcEP8+FZYxoR/A0YMQCQIzqw4cjf2ZCwOkzG8BW8 FHRgk6XN5M013p/tZUX8BO7O7QxDgBM30l+jJpycN/oyQd+WKMjRcLNm8durVtsS Rm7KHkocOBUGsjquD88Zx7CmJa3ZaGBMfPjWWPf3P8Bx8Rz0FHAjKr10I1tg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651642824; x= 1651729224; bh=e5z5SM6TeYreZEPQ1B3ojgUW3mglm9vAFtcWNVL9NFE=; b=E udx24VOmJ7aMYBGb6/YOwkFz5yJsA/3WH55r4uzmKzx5MkYgNaeqOvqy7q2oDRTo J8VN0CKTOI+BBCn8SeBeXc+4/WWgAfNGpK5HnZ74VQy4E1BuzLu1z8lT/GW9aHmr Lk0/ie3WfXwcyyfgXpk87EqSF9xfiajlSVyF7BAFe8I8gHxLLIduAr/8w/FvMuCa hu42UWhqinGV7exo7lISpJ4WX3iGcYo/D9UK69YwYU9yPCTvmq6v2fANbezVqwRH oZriA+oT4cFClR1RyckffBziVJDtLkbqcyUhHvTIweLCvO/aly8EyiGCUexOAQLk H2GfIEG9UNcV8eC6n65kA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekgdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgesthdttddttdertdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeelgeeggfdvieejvdfhudfggeetgfekkeeuieeljeejhedugeeg feetgefhueffkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 4 May 2022 01:40:23 -0400 (EDT) Original-Received: by athena.silentflame.com (Postfix, from userid 1000) id 6461B1B8B86; Wed, 4 May 2022 05:40:22 +0000 (UTC) In-Reply-To: Received-SPF: pass client-ip=64.147.123.21; envelope-from=spwhitton@spwhitton.name; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289144 Archived-At: Hello, On Tue 03 May 2022 at 10:14pm -04, Stefan Monnier wrote: >> * lisp/server.el: Require subr-x when compiling. >> (server-execute): Initialize the *scratch* buffer in the same way that >> the scratch-buffer command does, for consistency. > > Could we put that code in a function so we don't need to duplicate it > (and sync it)? There's a similar thing in a lot of different places in C, too. My own inclination is that it's simple, and in fact slightly different in different places, so not worth factoring out, but YMMV. -- Sean Whitton