From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: master 50020d026c: Untabify rcirc.el Date: Wed, 07 Sep 2022 12:11:50 +0000 Message-ID: <87leqvl6yh.fsf@posteo.net> References: <166254232836.24759.17163698181249816742@vcs2.savannah.gnu.org> <20220907091848.B4E13C04F04@vcs2.savannah.gnu.org> <878rmvphp9.fsf@gnus.org> <87tu5jmnvb.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16974"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 07 14:13:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVtvv-0004JI-Pd for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 14:13:31 +0200 Original-Received: from localhost ([::1]:34670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVtvu-00078d-N3 for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 08:13:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVtuP-0006Lj-Eo for emacs-devel@gnu.org; Wed, 07 Sep 2022 08:11:57 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:39375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVtuN-0008HY-47 for emacs-devel@gnu.org; Wed, 07 Sep 2022 08:11:57 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D89AC240027 for ; Wed, 7 Sep 2022 14:11:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662552712; bh=mFOcYGXGIQOOb1mhrc/anWasFrdfOjMx65YxBcwmens=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=hbufFxyxneP5pBmAVoVfQd4qVAU2HAW2qPtWPsSsLNOk2AOvcqaW8UhS2oktFx7xL BmLzeOC/jSEpiXm485bGCZDiKl9vUX1eQ1nGy3Xq/trV3ecqUPQ7pQ/+zHFUyiPo3U rzPgmAxHkCCCeSqQd64pp4uvOxnDXz1MJlQe5FokEMmP/+otHe0dQhp5J1GzJhgH7R ITNxAIOOfpdND69mIg/JsjxVosTiUkg27ZsemeMEz+DFDXLZaM3mQl161kC37bgSmJ QQ2pJ9n+YuoI8QqVucs7KCwsbNwl0Cukkf5MgaaLwiELZlmYlHa3GunJKjlcBNeXUK 0jt8qcIx4GqbA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MN1MX07tlz9rxd; Wed, 7 Sep 2022 14:11:51 +0200 (CEST) In-Reply-To: <87tu5jmnvb.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 07 Sep 2022 11:21:12 +0000") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294828 Archived-At: Philip Kaludercic writes: > Lars Ingebrigtsen writes: > >> Philip Kaludercic writes: >> >>> Untabify rcirc.el >> >> We don't do whitespace changes like this because it makes it more >> difficult to follow historical changes > > My apologies, I didn't know that there was a general rule like this. > The last few times I had been working on rcirc I always ran into issues > with whitespaces whenever indenting a function. Every patch had > unrelated whitespace changes that had to be reverted to that the > historical record isn't polluted. > > On a related note, I believe there has been a need to reorder rcirc to > make it easier to follow along for a while. But it goes without saying > that that would break the git history far more than this change. > >> (and applying any pending >> patches). > > That shouldn't be an issue, because git am/apply can ignore whitespace. I've also just found out that git blame supports this: Setting `vc-git-annotate-switches' to "-w" ignores all the whitespace changes when using vc-annotate.