From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: Amending commits Date: Tue, 27 Sep 2022 15:04:20 -0700 Message-ID: <87leq4bhjv.fsf@melete.silentflame.com> References: <87h70vbw2f.fsf@gnus.org> <877d1ru3rd.fsf@posteo.net> <87czbjbs4r.fsf@gnus.org> <834jwvmu84.fsf@gnu.org> <87mtama031.fsf@gnus.org> <83bkr2l61a.fsf@gnu.org> <87k05q73c7.fsf@gnus.org> <83a66mku8o.fsf@gnu.org> <878rm559qj.fsf@gnus.org> <87o7v0zv6t.fsf@melete.silentflame.com> <87bkr03jxh.fsf@gnus.org> <87edvwer2b.fsf@melete.silentflame.com> <871qrw3i6u.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35265"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , philipk@posteo.net, Emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 28 00:06:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odIiR-0008xx-LL for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Sep 2022 00:06:11 +0200 Original-Received: from localhost ([::1]:35806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odIiQ-0006He-H4 for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 18:06:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odIgj-0004I0-M8 for Emacs-devel@gnu.org; Tue, 27 Sep 2022 18:04:25 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odIgh-0002rs-Ro; Tue, 27 Sep 2022 18:04:25 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 651075C0059; Tue, 27 Sep 2022 18:04:22 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 27 Sep 2022 18:04:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1664316262; x=1664402662; bh=yg XxrejoJP1RLfpHbVleniN0SkbC/b03cPx540vtKns=; b=EC0oXvVJkXamHiCUy6 GIthB+99oU+6ba0XzDlYLD2A7oh567SKzPG9flvvH7/qD5MPouGPEiwRSgIhpZK0 S3aw4nsnyVuAfrxLL2cMiP3LFUCThNKkVng7bqzJ81Gf7sHHmiBByb4VXn0wNe2D d9e4TJckBV7+biMvAP/CJuzX2UY7VtektMBY+K9gg0MgPEYrloi8sUvjPlWsqnBu JhOo6Hm1udKP4idM7pwy/XkreSmNuM0jdxmep1J/FIK3ZH1h592Uz1XqOYAqvHty TGlSdek1W+LQsFCv4tX5O3dgWQpXWti6NTIxM6S/cMBqUpCUTeRm5rSdHySjwpz8 9f1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664316262; x=1664402662; bh=ygXxrejoJP1RLfpHbVleniN0SkbC /b03cPx540vtKns=; b=q85XNe40Pby79eqQkZXpz92ZuZSlY5m/s4Tr3uUqWSgv dEztAq+kWA2TagRK0tzOpjrGgb4Y1I3qXRKppcVMbQwuwn1T6mv+GRsS4XWo/rBA ehcuhv3JHqCGpYJYmloxwJOvJR1JeVZy1ezGTCQM9tvrnudX9DZl5m6c4NZlUYrW M0MnzJa0P/Ky2WWUHRghv+5u+YP1L4AWLVBAk9qCEcMayR9mHnvvTk/gMX5hoBFM fwbQU5Amci7tlVSs5qDkSHHmdOGPLqbQlzIM7Z5L3k6fQDoAymlhz3MxGU1puWW2 regyKdtOHtJ2muTTw0BPwDr0GB5Ks///UoFE+f0MOg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegjedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Sep 2022 18:04:21 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id D93097E0B54; Tue, 27 Sep 2022 15:04:20 -0700 (MST) In-Reply-To: <871qrw3i6u.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 27 Sep 2022 18:17:45 +0200") Received-SPF: pass client-ip=66.111.4.26; envelope-from=spwhitton@spwhitton.name; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296371 Archived-At: Hello, On Tue 27 Sep 2022 at 06:17PM +02, Lars Ingebrigtsen wrote: > Sean Whitton writes: > >> Couldn't it do a rebase to reword the old commit? I often do 'git >> rebase -i' only for the purpose of rewording an unpushed, non-tip >> commit, and it would be nice for that to be automated (eventually!). > > That should be possible (or un-checkin and then stash commits and > reapply), but sounds like major work. Right. If you're planning on working on the 'commit --amend' part, could you add an error specifically stating that amending the messages of older commits is not yet {supported|implemented}, please? Currently I think you just get a Lisp error or maybe nothing happens at all. Given that I do this a lot I'll probably look into the rest of it at some point. -- Sean Whitton