From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Sat, 22 Oct 2022 15:06:22 +0000 Message-ID: <87lep7sxsh.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <871qris3xb.fsf@gnus.org> <877d1aqoc1.fsf@posteo.net> <87edvhqdrb.fsf@gnus.org> <871qrh2hh6.fsf@posteo.net> <87mta5oyec.fsf@gnus.org> <87sfjx10x1.fsf@posteo.net> <875ygsp0ng.fsf@gnus.org> <87h70c9bu4.fsf@posteo.net> <874jw73cjy.fsf@posteo.net> <87edv72z11.fsf@posteo.net> <87czaq1i3k.fsf@posteo.net> <87fsfkhnhm.fsf@posteo.net> <87mt9s47f1.fsf@posteo.net> <871qr0kfeu.fsf@posteo.net> <87ilkcp25k.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8682"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 24 01:00:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omjwz-00022s-QG for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Oct 2022 01:00:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omh30-0004QP-Kw for ged-emacs-devel@m.gmane-mx.org; Sun, 23 Oct 2022 15:54:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omG50-00079J-8W for emacs-devel@gnu.org; Sat, 22 Oct 2022 11:06:30 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omG4y-00027M-Nf for emacs-devel@gnu.org; Sat, 22 Oct 2022 11:06:30 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 38DB0240029 for ; Sat, 22 Oct 2022 17:06:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1666451186; bh=BwkSQNsU3mgAkXn2tnW7KW1+dwj65uT/9kPcw1Ib2zg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=EMwIHbDsntY3snVzN+8T7jfoa4KOhdBecXXoadwxIj4B89upsKUrbZHKnnheu5d/M glQuSMzzOXOIpsP9pvE5gZYt+00BjFd49zm17edQEEVDVHsooSkRrBwYY2SZ2ILOU1 CLsfXvySh/UiHH5sQ4RVKwc2KMZ0MMS7Bdbkau+gqaFs+0tXaN7wPH/aEp98qmmN9N EtMDmalRccfVPJEjbYel5U46cskp3UgunA7UN8yn4YGUYRAQkICec6VSH5edJA7Lt+ 1TxyhYEVWBg4NvbAhVLiqK29sE7fsbXq5XKWUYGUTXIUbMVXtHgZhohVC8sjpihLke Gz38FtOe0Y5XA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mvl693DZdz9rxD; Sat, 22 Oct 2022 17:06:22 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Sat, 22 Oct 2022 10:53:53 -0400") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298276 Archived-At: Stefan Monnier writes: >> That was my mistake, I misremembered that core packages aren't mirrored >> in their own branches in elpa.git. I've removed it here: > > LGTM, thanks! > Feel free to push. > >> + ((and (plist-member (cdr spec) :url) >> + (null (plist-get (cdr spec) :url))) >> + `((,(car spec) >> + :url ,(concat "https://git.sv.gnu.org/git/" elpaa--gitrepo) >> + :branch ,(concat elpaa--branch-prefix (car spec)) >> + ,@(cdddr spec)))) > > The `cdddr` presumes the `:url nil` is at the very beginning (which is > a valid assumption, indeed), whereas the `plist-member/get` dance tries > to deal with the more general case. I think you can simply that to > > (pcase spec > (`(:url nil . ,props) ...) > ...) Good point, I will apply this suggestion and then push the change.