From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot Date: Tue, 13 Dec 2022 20:10:37 +0100 Message-ID: <87lenbrufm.fsf@gmx.de> References: <167080394233.4339.5863353994038854528@vcs2.savannah.gnu.org> <20221212001223.E9A9DC004BE@vcs2.savannah.gnu.org> <874ju07vzl.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3087"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 13 20:13:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5Ais-0000e3-9p for ged-emacs-devel@m.gmane-mx.org; Tue, 13 Dec 2022 20:13:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5AgW-0001iq-FU; Tue, 13 Dec 2022 14:11:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Afw-0001d3-3j for emacs-devel@gnu.org; Tue, 13 Dec 2022 14:10:53 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Afq-0007sW-D1 for emacs-devel@gnu.org; Tue, 13 Dec 2022 14:10:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1670958637; bh=iJLAvaqwSJazuZiG+UeEO/OfOp6TmrhpwAvMXXRdGY0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=iPNThRnda/y1Tb1R8Mc25Av2uka4VxAwWaC2WCwNi+cHncAqqcC8YdmjLcavltpGV blsecvJ1AXH2ZDba3UU1+3kfvbUsYFL5dTaJllpmos0ETLMVxFJmHC+g+3W4WMNuiW 8KO0heYZocRSd5+dj3w0zzofyCd4KxcSngzWPcTfSS9Vvz77NDHjYBSgJ0A6LFTMVS gg4JLsvLf6Hel5GYs3XuTMaLs9D11AL3GEpKcfyfwv5SPlSvKZ41F0LTtH0vfKGoMO 0orfWjUR19QUKbxKcbT4/+j1qdadPf7Zxyw3gTcoQFPuGKqMTK6VvLFniHy1Ec9wq2 H789SbLscIixQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.11]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N9Mtg-1osui12gxI-015FOV; Tue, 13 Dec 2022 20:10:37 +0100 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Mon, 12 Dec 2022 10:37:25 +0000") X-Provags-ID: V03:K1:fOAKmSfYiNdjoweISsNKQIITFMDgUZbJW5VX2Edujx0Y9r4vMSb pMIg6BdAi3zp+ys3QXa4HZlvaduB/Q3aVKCTCEXwoF29WgvrDtQR/pnbEiUmBsgZLkeJleG BKg+xXaq6wGyf0Qt37QZ/HpKcEcjTihPv3iTBSbz/lM7ybbl0+r/g8S/stPWca3OjwBxo0H xqdplEcQxPss0h5ebmoGA== UI-OutboundReport: notjunk:1;M01:P0:RVYo0huI6Z0=;wx3HDPKK0PRZVMiJ1odqaxn5dIn 5e1iHsKY4dlEHPHFqJRt3nFksqHmU/79BF4uy9Fqf57dmzQcdUuRT8gocFnwQLVALWlCazk5E t0k28SFif1mUoFiLrmN1gKdj3gTQspigZaEIBFYB8MIWdxXKYUw0XMREqtlpKiLDV/yY+eERZ 53Er7KPttvX0lrHomvV+KfudLQQDeJS7NZiae5a0oFWUuOcNSD2vP9+wbB1hkS4nwgAesBqhC BWPd5jqcLNIH2QQHg4Kke3fnT+yYPdxeqB7qyt0fZ7HBBv+3rkMr41lxIp8jtBJIQsuFDquhn Lqn3vhP/K6SQacAMT5cQpXDS+06hXbgv15wkRajQQI0fBvQy9/DGmT6sWj0UWfJUUcEfDhL5p xVE5ZppAn9eL16F+awI4NJtGZHVNblXoxbSuXYzGq6sx3ZGG7zou/3YQfC4wK2feTrMEXfysb /QX630dhEYooOP+BusTKgeGukLX8XpNruxCM8gpnWj/taNcUBgf4fCpT8o77byc3JYVzrTPKC 2qaYKE5afcH5t0P3j4IB3/Q0EmuhQAvrEHEoc9gNnWX38vONVjgksrCYwqldXe/9+Ub/XljXf BP+vu9yLlRjMHobrp8pczoXhhFY9cXu/qMGEp2St9JDniaKVRVbaWYWpowFseaoDuluJOd9cE x13jMncFRtUM/2CA29qK7HnkMxKTkF/t30zJCvs0yEUEu3ktb4WQ4zuUDF08Cf+M30lG1/Php 9bdHlxkhOO07H8VlPYSJc+cczEV0i6YniidsT0KQBiSRgQ0ub0mYOfQFXvNFEw5sqnJ7Khei Received-SPF: pass client-ip=212.227.17.21; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301351 Archived-At: Jo=C3=A3o T=C3=A1vora writes: Hi Jo=C3=A3o, >> Do you really need this? > > Flymake tells me there are 4 compilation warnings if I don't: > > 1243 9 warning e-f-b-c Unused lexical variable > `tramp-remote-path' > 1243 56 warning e-f-b-c reference to free variable > =E2=80=98tramp-remote-path=E2=80=99 > 1244 9 warning e-f-b-c Unused lexical variable > `tramp-histfile-override' > 1245 9 warning e-f-b-c Unused lexical variable `tramp-methods' > > Here, the flymake backend 'e-f-b-c' (elisp-flymake-byte-compile) > compiles with Emacs -Q > and no specially relevant load path in these cases. I've fixed this in eglot-tests.el. I've also adapted the two tests wrt Tramp. Pushed to the emacs-29 branch. FTR, I'm suprised about the names of the test cases. Would it be possible to give them a unique prefix, like `eglot-test-'? > Jo=C3=A3o Best regards, Michael.