From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: tree sitter failures Date: Mon, 30 Jan 2023 21:32:30 +0800 Message-ID: <87lelkywpd.fsf@yahoo.com> References: <87lelkywpd.fsf.ref@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34576"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 30 14:33:55 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMUIE-0008qs-71 for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Jan 2023 14:33:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMUHC-000514-AV; Mon, 30 Jan 2023 08:32:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMUHB-00050i-2M for emacs-devel@gnu.org; Mon, 30 Jan 2023 08:32:49 -0500 Original-Received: from sonic304-21.consmr.mail.ne1.yahoo.com ([66.163.191.147]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMUH9-0007tt-4B for emacs-devel@gnu.org; Mon, 30 Jan 2023 08:32:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1675085563; bh=QzZLhU2bExGF1kOj2uvQshMyr3kOtuvJwDZ7QND9ulE=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=eLKQAj186Aex5vS3uUo8asbjhudUwN+7z7vxi5djhP/IDlPmsJ+dWUxOD28JT2/R2yf1ygWH7Gl7tVvctBT74Kd0wUDs3DZyYOvpeyAw1Qyv4VTaDx+M7ppR4qZEb2L9SE4dLU8myxDU9k3MbLf4nz0/JMoQnJezvMJLBG662o/V0AuPQMNp8c6S9/OlmTUSKpK4EOP4DmsGNVTWhwxOS4mltEGcJspw8/kj4ogP2M4Re2efVo+1awpVggEUh5CKgWh5s0EApvIRoDeGXQuqtRKObLXeZFQsJ82oJr9SOyTf3FQ8pn3Kbu5q7qvenesU/tq6PRYpzlgZLVL3YELPXQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1675085563; bh=NiOtlwdLYLuNU+7ic8W26l7bxXrHbel8iaElJdt6GV/=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=A0/ZR4JdBlrlUPkONNwMyxcD8Cywgnf2NCl/nsyRyVF9InYjjgFgAChgBRpPJm0L5XZ/U3MJOQT0NTWxjHTEUC0oUHcmcNpW7eDfXu86G5ZDz+CrgkrvyfWnw30D5TlAyZAEy3HcT64jdnQxhiYORv5j2rF7Pe2Jm8kTnC67sr/Z9N6BNNGSSL1Vu92Y1424tnkEyVzyo5GodPXTriqTtOm45X6WBosVNVZSEcbLbAIvHGYLigPp2+ZMkbrl6r8KSOJ9IixVOcn824lZ4AIH3glHRimx6MSta+ZiEKGqLf/ZUpIxEJ8ac2qHa+2oI5JKOAvw7Gw8VMetfkc4idSv6A== X-YMail-OSG: 88SHMmQVM1lvSUQfnrvj8yHNTSDv4DuhvPIVfRiY_I06C9tAkepBRwPvDA00Kvi uC0Ov_6kaH9gK4o4wSpsynSEP.cGTK9Ui_wVVnqbFS2_4bUtFuLKpDD7.A2rF2uWOQCnK5uanCM6 U.t9HbQg2q.cI.qmMvzmnjXXfC_BbID0qysM8vOnabKdXyr3ZHxSQuWM3iSRwCfuLmAhrBehIgFy FufoBIhQcDCn56hjJyB.jPZhJ9nBk78t1n.SXh1WlackwP7FChMWtg5m5LrGDAcbg6ipLH9YgvXg UDRiUlB34YNkElv0LDqj52jQmX4D.7kO2vDyoxrAc38WG7pVr6_fGu.8lY9aqvpwSHokLc4iQ5Xx F2wN2jgkpHePUtlvhp8VKyevaVMvUwoRWm72SGbCPawxFnMnftotQJdDcYFL4xXW8RSMDSzkavoi jx85xvje2bvRBT2u6zlU8rXiGpnoPaqvDP065I8TwXHx_32AiwIyWoGTTepbzLzVKevKr1Obw3WE oKTaynCnQcxi_ysjc4xdN9IuzI2SErmpYfmClUDa0dYA1GgiooNhw49GbQ_pdF0i8CtL68dc.LC2 NL4Lbksp8ipTM47AJD_SAmQTtikeGDlSi8lQOOODRIBFDcuqennvz7W2Eb5_h8JJADGKoWjRTegX U8JmgDy07y3EnQzhBe3Dn67ubh1bUkb12DM2lLlpiMoWTm1Gegqa43fsSo1PgD9qiGNcaHvwiEip aaReICU5EN39Uc_oG5KBzNDTG.OMB9SRUXrILUdJawZBJLcBe2pnOIlVrg5YSFnF2WnxAncNdY1I d5ika3ZjyYzesyC8kDMcD_PjG.dJfw_ajDjnv4eifC X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Mon, 30 Jan 2023 13:32:43 +0000 Original-Received: by hermes--production-sg3-9fc5746c8-8hlql (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ebc4e4bc3c139a887bd4df8e4f4f95f5; Mon, 30 Jan 2023 13:32:36 +0000 (UTC) X-Mailer: WebService/1.1.21123 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.191.147; envelope-from=luangruo@yahoo.com; helo=sonic304-21.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302780 Archived-At: Since some recent change the incremental build has stopped working, with the byte-compiler complaining that it cannot find `treesit-buffer-root-node'. I have installed this change to fix it. But why is pcase-let or the byte compiler evaluating a binding during macro expansion? That sounds like a bug somewhere. diff --git a/lisp/treesit.el b/lisp/treesit.el index c9f2e339dc2..202a383ed7d 100644 --- a/lisp/treesit.el +++ b/lisp/treesit.el @@ -86,6 +86,7 @@ (declare-function treesit-search-subtree "treesit.c") (declare-function treesit-search-forward "treesit.c") +(declare-function treesit-subtree-stat "treesit.c") (declare-function treesit-induce-sparse-tree "treesit.c") (declare-function treesit-available-p "treesit.c") @@ -265,12 +266,14 @@ treesit-buffer-root-node Use the first parser in the parser list if LANGUAGE is omitted. If LANGUAGE is non-nil, use the first parser for LANGUAGE in the parser list, or create one if none exists." - (if-let ((parser - (if language - (treesit-parser-create language) - (or (car (treesit-parser-list)) - (signal 'treesit-no-parser (list (current-buffer))))))) - (treesit-parser-root-node parser))) + ;; Otherwise the incremental build is broken without tree-sitter. + (when (treesit-available-p) + (if-let ((parser + (if language + (treesit-parser-create language) + (or (car (treesit-parser-list)) + (signal 'treesit-no-parser (list (current-buffer))))))) + (treesit-parser-root-node parser)))) (defun treesit-filter-child (node pred &optional named) "Return children of NODE that satisfies predicate PRED.