From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 2ef6f943abd: Add option to control default outlining in 'C-h b' Date: Tue, 25 Apr 2023 10:25:51 +0200 Message-ID: <87leig9xm8.fsf@gmail.com> References: <168233653969.13461.3810563138120581789@vcs2.savannah.gnu.org> <20230424114219.F2AEAC0004A@vcs2.savannah.gnu.org> <877cu1bf6q.fsf@gmail.com> <834jp5xn7v.fsf@gnu.org> <87a5ywn4qj.fsf@web.de> <83r0s8wjcf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40825"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Heerdegen , emacs-devel@gnu.org, Matthias Meulien To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 25 10:26:46 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prE0c-000AOn-4d for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Apr 2023 10:26:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prDzs-0002ob-Ig; Tue, 25 Apr 2023 04:26:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prDzq-0002oQ-O1 for emacs-devel@gnu.org; Tue, 25 Apr 2023 04:25:58 -0400 Original-Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1prDzo-0004gQ-K3; Tue, 25 Apr 2023 04:25:58 -0400 Original-Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3f1950f5676so43203355e9.3; Tue, 25 Apr 2023 01:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682411152; x=1685003152; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=T5tGA3/FJQAQWVEyneb+ykU0zY/M5oMBewaJwSzaoxs=; b=SnbLH3ZrOFL0iuA6072RvUOHQIAPw1ltm+1qJ8onpUOmxo942dH8mfyxLL+tZrcLtt F9Sihnr5B5FLhbmBdulcByytD9K6JaeOe1DtuJhqH9m6xUxQff57SgmQdapH4FqfMYbC y04EpqDwxzftBaHSBTuxosYwkCK8hz4goZaONJ3MxCFcyaVbwl7aKsYVLR47IYk3oWT4 +bKJVRtUPUzE9v6hhaZjblRgVB8ZCze/DQlMA4ADlmmH2h67mkZzuQwtNjt62doJqEzc R6OwtZL5p0HFFiZ4MXzEVKmcz+4pcFARm6CwWGfLMYasI4fEG86M0+Zx2vFDu709RnQJ EXtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682411152; x=1685003152; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T5tGA3/FJQAQWVEyneb+ykU0zY/M5oMBewaJwSzaoxs=; b=Uq8DRh/1adjn7PVXz89/TRhrdQRRkv2sY/BdEsd0flQCb4hVO8zvnmSRMYrzLHCtOl lX1LJtDo1HRz+WKVKHyNNu4dDbl2sYSc2RIA0ktAw2GUqYx6SxCf5Xetu60pXXvRBsjq HIepBOioeXXBbbWXlwyLkaX+vviOEEsY7RrJLGH9a0YUy9jVzASZSYa/jVevpylrre/R uRfrjeRKfOlu7B7HNg5SItDHHGHkIxXhqj1ibPUEtizR2k16lIi+LDSzPeUZ47QH/N32 lRvNqnqekQkJo1TNIUkKidDeYCeoLHHYjwx+yfQTRrV2/Zl9VKS5T2Y+3sgxbbJlpMy7 4Cgw== X-Gm-Message-State: AAQBX9e4egkocWZm1Df9C027Dcfp15a/qaCeWG/zYA/u5ZRc0HDl4Spp 7ZCg0LaJ8xwKjC0+xpXhYdg= X-Google-Smtp-Source: AKy350anae+JsR2zF7qCHXwWTfHwiGQ2Dy2aZeYZs/F2k5jsC6SD2nHAJ92K457OmSuQ1MWUdFWgXw== X-Received: by 2002:a7b:cd07:0:b0:3f1:9503:4db0 with SMTP id f7-20020a7bcd07000000b003f195034db0mr9263192wmj.13.1682411152394; Tue, 25 Apr 2023 01:25:52 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id p13-20020a7bcc8d000000b003ee63fe5203sm14282593wma.36.2023.04.25.01.25.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 01:25:51 -0700 (PDT) In-Reply-To: <83r0s8wjcf.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 Apr 2023 09:45:36 +0300") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=rpluim@gmail.com; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305643 Archived-At: >>>>> On Tue, 25 Apr 2023 09:45:36 +0300, Eli Zaretskii said: >> From: Michael Heerdegen >> Date: Tue, 25 Apr 2023 03:13:40 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> + (cons :tag "Custom function returns non-nil" >> + (const custom-function) function))) >>=20 >> AFAIU this tag is misleading, though: `outline-default-rules's doc t= ells >> that "[...] the function being expected to toggle the heading >> visibility." Specifying a predicate functions doesn't suffice. Eli> Feel free to suggest a better tag, TIA. Bonus points for untangli= ng Eli> the IMNSHO confusing documentation of outline-default-rules in the= se Eli> areas (e.g., what does "function is expected to toggle the heading Eli> visibility" even mean??) and fixing that and the related tags as w= ell. Eli> I simply had no time for that, sorry, and saying just "Custom Eli> function" without any hint what that function should do seemed lik= e a Eli> bad idea. The custom function is just funcall=CA=BCed, which is somewhat unfriendly, since it forces the user to understand the details of how to hide headings, which are not documented (what happens if the custom function does nothing?). A predicate function would be more useful. This code and the defcustom is new in emacs-29, so we can still change it to be a predicate instead. At least we should document is better Robert --=20