From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master bb9133f09da: * lisp/emacs-lisp/ert.el (ert-run-tests-batch-and-exit): Inhibit interaction Date: Mon, 14 Aug 2023 17:01:16 +0200 Message-ID: <87leedwtvn.fsf@gmx.de> References: <169195451549.1474.16374421496442723026@vcs2.savannah.gnu.org> <20230813192155.C53CEC295F9@vcs2.savannah.gnu.org> <87ttt22j2a.fsf@gmx.de> <18DBF0B1-8534-48C2-B5FE-4B324A93AB2A@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10214"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 14 17:02:27 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qVZ5O-0002Uy-Oo for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Aug 2023 17:02:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVZ4U-0000U7-7m; Mon, 14 Aug 2023 11:01:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVZ4R-0000Tp-Au for emacs-devel@gnu.org; Mon, 14 Aug 2023 11:01:28 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVZ4P-0005fA-9A for emacs-devel@gnu.org; Mon, 14 Aug 2023 11:01:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1692025278; x=1692630078; i=michael.albinus@gmx.de; bh=JI+cPrUdhz7TcGx90h0cAO6xgE73U+uTBn8aAW4SMgg=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=lRM1NU/Cb1fmR+OA2BWfyLBJpF7YRe1SQ+BfYiu7Br2AkKCD2dtrcb0z9uj1myYjyzuCV99 PAkn6goUuxpvq9EAaqfiFnjYEqYP21WK4LwGVaRhiGHfjVyO9FUS6q375lWJ+1XiFEOUTzNxK JpKJLIoLTmoonDSIFKZ/L6o3i/bWRgV98qcoXv8fqpF0tbsXoAdUhqn5W+2T+2Chf9yibIV8x MNVHurxtpCFnaou6DuBud7SyLxd1ftPga/dQk/tH91Fdw0UHFzY1ED5y+/aHNF90c14pefIzV Yj4UmpThdNazd839Rg16AKcVD33Z5QgHE/kWxboh0HiCJtveFeNw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.27]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MZktj-1qJB8c2v2d-00WpKP; Mon, 14 Aug 2023 17:01:17 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 14 Aug 2023 10:39:26 -0400") X-Provags-ID: V03:K1:BoXO5+mNkgOxeCTepM/qu3Qj/CUkRimoNVDikCaSla76pHxwt2P mW6S0TrNYHNK0I77AcrGCqNpkcgogDpptFCIv7KJc5xtFL5j0tqZHrGYE902+O8nrpO7piv i8H7MMH7lD3l34fgMMVnQptobEOKZHVBjmE9jwQAee1VIgJ8IFVBN47bJTU4UiNYcxq7dkT whtWMupoEjxaIb5W55Chw== UI-OutboundReport: notjunk:1;M01:P0:R5QWqj7nq5Y=;bmokzL+1oW2Exg2If9HzI4sFJyX bzWUQDw2Cjr3gdztM1BEletT6+0h5w+PRRUQpJGif9+bPxOQPrm67dsMQNA7WnKs8KW3nm2IB P7JfMjIxn/yVzV8Favxjwnwfc7NBfd/TkiaHPzpVu/LsLVq6TZVjNd+MJvoBfka0mQq95k4ga FnDGcKmsKV3cpK3lGHyrUCIosxzdXnNm4PKRIrn+6kUIWmvTnF1CLco1iLAisuEQgfd921/1D W5lBO5qoVcETx4vMC9//sCSp/8hCINXf7ZMZ3WOS55bYeSGgTVDoSmBXU+dKN15zns+1y/tJz zOe9J2Fr5ztBiHOfHxCa43fMi4H0dUHSTbBJLff7tmnBcdhoSYvSWlvFW8xFaVTBc8X6jj+Qn N3RZBWVnbOETC0aojICaIl8VTzECF9V9BRfTyQuAuWdjXFCt+VUpL1WRRFK6L1PqctaedViBV X4Mho6kYTjl488dUyTyubAVsN9lPTy30OdJzNhQ69595j46Nod6D9PR3orMQMXb8haasyi/46 esNbosHL9+qN4FN+qT6jS69G5E4qN88Wvvxg4pYM+UUbDTZvih55UERpBl2ZnlEeXyEpBjZdC qKceEpI0DmSrsxhNh796H31KLczTOB3q40YCu31t673pJci72ny9UvgDI8KiSigmY0WCoOLrh xlffinjrtwYZJlgeRiUwcCWm0ocEIR+GWqe+yRreo7WNTKEv8ka1ICfFIDNes1Js6kmG75atS /r80UvzUOwzHZwsKCsPdFOFllPuNHiEGa+jopcWR/lKs2agTEziPNU9m8j4LrMjhDc7oHUtE Received-SPF: pass client-ip=212.227.17.20; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308739 Archived-At: Stefan Monnier writes: Hi Stefan, > Oh, I think I see: `inhibit-interaction` is probably tested too early, > e.g. upon entry to `read-event` (which can return without user > interaction if there's enough `unread-command-events` and friends) > instead of upon entry to the actual code that waits for user input, so > it doesn't quite do what I thought it would. If you want to check yourself, here are the tests which failed due to the (inhibited-interaction) check on emba: --8<---------------cut here---------------start------------->8--- FAILED 50/91 tramp-test26-interactive-file-name-completion (0.004941 sec) at lisp/net/tramp-tests.el:4841 FAILED 1/22 abbrev--possibly-save-test (0.004799 sec) at lisp/abbrev-tests.el:308 FAILED 1/7 auto-revert-test00-auto-revert-mode (0.215386 sec) at lisp/autorevert-tests.el:146 FAILED 2/7 auto-revert-test01-auto-revert-several-files (0.385464 sec) at lisp/autorevert-tests.el:191 FAILED 3/7 auto-revert-test03-auto-revert-tail-mode (0.033018 sec) at lisp/autorevert-tests.el:335 FAILED 4/7 auto-revert-test04-auto-revert-mode-dired (0.098083 sec) at lisp/autorevert-tests.el:370 FAILED 6/7 auto-revert-test06-write-file (0.035447 sec) at lisp/autorevert-tests.el:538 FAILED 7/7 auto-revert-test07-auto-revert-several-buffers (0.042405 sec) at lisp/autorevert-tests.el:572 FAILED 2/6 find-func-tests--library-completion (0.001559 sec) at lisp/emacs-lisp/find-func-tests.el:32 FAILED 4/5 viper-test-undo-3 (0.057615 sec) at lisp/emulation/viper-tests.el:118 FAILED 1/5 erc-add-entry-to-list (0.000351 sec) at lisp/erc/erc-match-tests.el:27 FAILED 11/15 erc-nicks-customize-face (0.127834 sec) at lisp/erc/erc-nicks-tests.el:441 FAILED 3/9 erc-sasl--read-password--basic (0.029777 sec) at lisp/erc/erc-sasl-tests.el:35 FAILED 17/17 erc-nickserv-get-password (0.002919 sec) at lisp/erc/erc-services-tests.el:534 FAILED 4/54 erc--check-prompt-input-for-excess-lines (0.000534 sec) at lisp/erc/erc-tests.el:1187 FAILED 13/54 erc--interactive (0.002051 sec) at lisp/erc/erc-tests.el:1829 FAILED 26/54 erc--switch-to-buffer (0.001627 sec) at lisp/erc/erc-tests.el:465 FAILED 46/54 erc-select-read-args (0.000371 sec) at lisp/erc/erc-tests.el:1606 FAILED 50/54 erc-server-select (0.008819 sec) at lisp/erc/erc-tests.el:1865 FAILED 52/54 erc-tls (0.058334 sec) at lisp/erc/erc-tests.el:1713 FAILED 5/18 file-notify-test02-rm-watch (0.045676 sec) at lisp/filenotify-tests.el:396 FAILED 6/18 file-notify-test02-rm-watch-remote (3.690951 sec) at lisp/filenotify-tests.el:1 FAILED 7/18 file-notify-test04-autorevert (2.026364 sec) at lisp/filenotify-tests.el:937 FAILED 8/18 file-notify-test05-file-validity (0.023406 sec) at lisp/filenotify-tests.el:1039 FAILED 9/18 file-notify-test05-file-validity-remote (3.579880 sec) at lisp/filenotify-tests.el:1 FAILED 12/18 file-notify-test07-many-events (0.023911 sec) at lisp/filenotify-tests.el:1220 FAILED 13/18 file-notify-test08-backup (0.009403 sec) at lisp/filenotify-tests.el:1298 FAILED 14/18 file-notify-test08-backup-remote (1.419481 sec) at lisp/filenotify-tests.el:1 FAILED 17/18 file-notify-test11-symlinks (0.011308 sec) at lisp/filenotify-tests.el:1581 FAILED 18/18 file-notify-test11-symlinks-remote (1.899609 sec) at lisp/filenotify-tests.el:1 FAILED 2/13 mule-cmds--test-universal-coding-system-argument (0.000393 sec) at lisp/international/mule-tests.el:45 FAILED 25/44 kmacro-tests-step-edit-edits-macro-with-extended-command (0.001692 sec) at lisp/kmacro-tests.el:800 FAILED 3/25 completion-auto-help-test (0.000958 sec) at lisp/minibuffer-tests.el:346 FAILED 4/25 completion-auto-select-test (0.000783 sec) at lisp/minibuffer-tests.el:374 FAILED 5/25 completion-auto-wrap-test (0.000320 sec) at lisp/minibuffer-tests.el:396 FAILED 24/25 completions-affixation-navigation-test (0.000354 sec) at lisp/minibuffer-tests.el:453 FAILED 25/25 completions-header-format-test (0.000346 sec) at lisp/minibuffer-tests.el:425 FAILED 4/48 eglot-test-basic-completions (0.363706 sec) at lisp/progmodes/eglot-tests.el:540 FAILED 5/48 eglot-test-basic-diagnostics (0.280194 sec) at lisp/progmodes/eglot-tests.el:421 FAILED 12/48 eglot-test-eldoc-after-completions (0.440281 sec) at lisp/progmodes/eglot-tests.el:639 FAILED 14/48 eglot-test-formatting (0.424955 sec) at lisp/progmodes/eglot-tests.el:672 FAILED 19/48 eglot-test-multiline-eldoc (0.334466 sec) at lisp/progmodes/eglot-tests.el:655 FAILED 20/48 eglot-test-non-unique-completions (0.290398 sec) at lisp/progmodes/eglot-tests.el:556 FAILED 19/29 query-replace-search-function-tests (0.009815 sec) at lisp/replace-tests.el:459 FAILED 20/29 query-replace-tests (0.000823 sec) at lisp/replace-tests.el:411 FAILED 2/13 ses-jump-B2-lowcase-keys (0.010933 sec) at lisp/ses-tests.el:213 FAILED 34/48 simple-test-undo-extra-boundary-in-tex (0.078750 sec) at lisp/simple-tests.el:694 FAILED 2/10 whitespace-tests--empty-bob (0.001325 sec) at lisp/whitespace-tests.el:130 FAILED 5/10 whitespace-tests--empty-eob (0.001189 sec) at lisp/whitespace-tests.el:232 FAILED 1/3 xt-mouse-tracking-basic (0.412822 sec) at lisp/xt-mouse-tests.el:60 FAILED 2/3 xt-mouse-tracking-sgr (0.001347 sec) at lisp/xt-mouse-tests.el:101 FAILED 3/3 xt-mouse-tracking-utf-8 (0.001496 sec) at lisp/xt-mouse-tests.el:79 FAILED 1/2 inotify-file-watch-simple (0.008711 sec) at src/inotify-tests.el:52 FAILED 2/2 keyboard-unread-command-events (0.000233 sec) at src/keyboard-tests.el:24 FAILED 27/32 threads-signal-main-thread (0.002614 sec) at src/thread-tests.el:325 FAILED 6/10 xdisp-tests--minibuffer-resizing (0.007032 sec) at src/xdisp-tests.el:35 FAILED 7/10 xdisp-tests--minibuffer-scroll (0.000490 sec) at src/xdisp-tests.el:55 --8<---------------cut here---------------end--------------->8--- > Stefan Best regards, Michael.