From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Is it better to add treesitter modes to core? Date: Tue, 09 Jan 2024 20:21:02 +0000 Message-ID: <87le8yqmvl.fsf@posteo.net> References: <87a5phiap4.fsf@posteo.net> <871qas8i6s.fsf@posteo.net> <83a5pgq9f4.fsf@gnu.org> <8734v6s3wp.fsf@posteo.net> <83wmsinuy4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25495"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, stefankangas@gmail.com, emacs-devel@gnu.org, stephen_leake@stephe-leake.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 09 21:22:45 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNIcX-0006OG-Ev for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Jan 2024 21:22:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNIb3-0003RK-EC; Tue, 09 Jan 2024 15:21:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNIb1-0003Qz-Sy for emacs-devel@gnu.org; Tue, 09 Jan 2024 15:21:11 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNIav-0005k3-MS for emacs-devel@gnu.org; Tue, 09 Jan 2024 15:21:10 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D5CA4240103 for ; Tue, 9 Jan 2024 21:21:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1704831663; bh=bOb55OpAHbEGN1S7HZyduVcRDRYqL3/wbn4utWxE7Ds=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: From; b=BQXoNQCuTbnOiZ+WKKucPCGox1nDoH9D4XZQEKxr135osQWWaj/hR07b4Zpm5vTFk 9i1hy65XGIKxMRAMljvR7T2ezOkHzOI5OVDqLgRFO51Yihg8z6P9H/mSXjYe3LCCTV +MgnqHif7+vU3yLx3NXqOiyRyi0qMUdx0hRUoAtbhYLXG0hLqZTohcJVwxsDpfi+P0 rFKUH+LkmoFnW8t2OIKijta5J7sSkmQatmwP4XyXFdL1cbKFJnMkTwnx0LAHtZaf14 t3sueLOY8RHd5j7ETKgW2NxTpVDaoz+LPd8C+W8qnU5Fpj/jDGl2hA/JqPAELatTV8 oVFOOXazJPuww== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4T8j4G661jz6twZ; Tue, 9 Jan 2024 21:21:02 +0100 (CET) In-Reply-To: <83wmsinuy4.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Jan 2024 21:54:59 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314794 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: dmitry@gutov.dev, stefankangas@gmail.com, emacs-devel@gnu.org, >> stephen_leake@stephe-leake.org >> Date: Tue, 09 Jan 2024 19:27:50 +0000 >> >> Eli Zaretskii writes: >> >> >> From: Philip Kaludercic >> >> Cc: Stefan Kangas , emacs-devel@gnu.org, Stephen >> >> Leake >> >> Date: Mon, 08 Jan 2024 06:15:07 +0000 >> >> >> >> > Possible grammar versioning problems. But the above should be small >> >> > and stable enough, nor should they require many changes over the >> >> > years. >> >> >> >> I don't think this has to be a problem. Last year I had suggested that >> >> `treesit-install-language-grammar' should download release GitHub >> >> tarballs, not just clone the repository (which requires Git, and is >> >> prone to upstream breakage). >> > >> > Alas, this solution is incomplete, because some grammar libraries >> > don't have releases at all. >> >> Most if not all git forges should support requesting an archive for a >> specific commit (basically git-archive over https). For example, this >> will provide a tarball for the current newest commit for the python >> tree-sitter library: >> >> https://github.com/tree-sitter/tree-sitter-python/archive/4bfdd9033a2225cc95032ce77066b7aeca9e2efc.tar.gz > > I was responding to the suggestion to download release tarballs. Then I misunderstood you, my argument is just that we could avoid grammar versioning issues by fetching specific revisions (be it by commits or by releases), and that we don't even have to use git for that.