From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rahguzar Newsgroups: gmane.emacs.devel Subject: Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470) Date: Sun, 21 Jan 2024 16:07:31 +0100 Message-ID: <87le8ira14.fsf@zohomail.eu> References: <170030013667.20571.18090141972402319489@vcs2.savannah.gnu.org> <20231118093537.9F147C0C994@vcs2.savannah.gnu.org> <87a5p1679r.fsf@gmx.de> <83a5p0til9.fsf@gnu.org> <87a5oz0w8b.fsf@gmx.de> <87ttn6rfre.fsf@zohomail.eu> <877ck26cuu.fsf@gmx.de> <87plxuravt.fsf@zohomail.eu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8652"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.10.5; emacs 29.1.90 Cc: Michael Albinus , Eli Zaretskii , emacs-devel@gnu.org To: Rahguzar Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 21 17:02:07 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rRaGr-00020x-Ja for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jan 2024 17:02:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRaGK-0003Md-4J; Sun, 21 Jan 2024 11:01:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRZZa-0003D1-1G for emacs-devel@gnu.org; Sun, 21 Jan 2024 10:17:22 -0500 Original-Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRZZY-0003jJ-7w; Sun, 21 Jan 2024 10:17:21 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1705850234; cv=none; d=zohomail.eu; s=zohoarc; b=DOPEQhEUaB39cMbZ0wIaLwGodiSjUWG+VgUcVm3vJeqkNhY9xDPhLTYxAd89v1neKOqg3LGd0WFrH/eQFUDfPzmzTJ1HOBTHE3pq8pyh8eA5AK0e3CmLYsQ6MS69vXp1o3VwSAn7FUOCwPt5ZBGYk7g/J6Rk6KHws6rIdEG2UZY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1705850234; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=eLQTKk+8g0AFU8DiTLhO4oqZoK4zEsX0CJMzBump3EI=; b=bzuj7Zs5z5t8z4WDDSAYntqLkk7PMPOnliPIpvTKSU9Xfc5hxXF1Rw+w52B0PY/tvaP5khV3BQA/UpY3ENwikrYTIF8jL+6JG2eydFmm5cHnay/riF4dxYYAmtFbQoHnosMuMSGrAllmDDDZbDwb0TgKys2BrzweekPfZ24vZMI= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1705850234; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=eLQTKk+8g0AFU8DiTLhO4oqZoK4zEsX0CJMzBump3EI=; b=VaeGMJQF793muWm8s6M4kjB05X3znvJHvMf4Q4hL268Qgfs86HMMRV7rsANqeXvL D1t5KPVhM5DBEGvHkWeoqQE+bbCW0HRqJ9GMYtAz1sLMQisO9LD2+gi2hHbh+VF9gdQ a8oACnNqieqjB0Qai9z6tfCtmY0+Oque3R47YiY4= Original-Received: from localhost (78-73-246-128-no600.tbcn.telia.com [78.73.246.128]) by mx.zoho.eu with SMTPS id 170585023337565.9933458752472; Sun, 21 Jan 2024 16:17:13 +0100 (CET) In-reply-to: <87plxuravt.fsf@zohomail.eu> X-ZohoMailClient: External Received-SPF: pass client-ip=31.186.226.249; envelope-from=rahguzar@zohomail.eu; helo=sender11-pp-o91.zoho.eu X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 21 Jan 2024 11:01:28 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315179 Archived-At: Actually I see what is happening now. `cus-test-deps` is checking if it can load the files defining the custom variables. None of the files in lisp/leim/quail are on the load path. The cases where require succeeds it is because some other file with the same file-name-non-directory is on the load path e.g. for indian.el it is, lisp/language/indian.el which does not define any custom variable. I think the problem is with the test. P.S. Both lisp/leim/quail/indian.el and lisp/language/indian.el provide the feature indian which doesn't seem like the right thing. Rahguzar writes: > Hi Michael, > > Michael Albinus writes: > >> Rahguzar writes: >> >>> Hi Michael, >> >> Hi Rahguzar, >> >>> So I wonder if the test is encouraging the correct behavior. I think >>> that seeing the `pakistan-urdu-input` subgroup would be useful for >>> people using `urdu-custom` input method but perhaps for majority of >>> people we shouldn't cause pakistan.el to load just because they wanted >>> to customize a quail option. >>> >>> Maybe it is better to just remove `quail` as the parent group of >>> `pakistan-urdu-input`? >> >> No idea. Note, that there is also lisp/leim/quail/indian.el. It declares >> defgroup `tamil-input', and it doesn't show an error in the test. >> >> I've tried to replace the parent group of `pakistan-urdu-input' to be >> `leim' instead of `quail'. But the error about the missing pakistan.el >> persists, just using `leim' instead of `quail' in the error message. > > Poking around `cus-test.el` a little I think this is a load path problem > and unrelated to the defgroup form. > > I can run > > src/emacs -batch --eval="(require 'indian)" > > in a shell and it exists without any error. > > But > > src/emacs -batch --eval="(require 'pakistan)" > > results in > > Error: file-missing ("Cannot open load file" "No such file or directory" "pakistan") > mapbacktrace(#f(compiled-function (evald func args flags) #)) > debug-early-backtrace() > debug-early(error (file-missing "Cannot open load file" "No such file or directory" "pakistan")) > require(pakistan) > eval((require 'pakistan) t) > command-line-1(("--eval=(require 'pakistan)")) > command-line() > normal-top-level() > Cannot open load file: No such file or directory, pakistan > > Similarly starting with > > src/emacs -Q > > M-: (require 'indian) RET > > works > > but > > M-: (require 'pakistan) RET > > doesn't. > > Neither do any of, > > M-: (require 'ipa) RET > M-: (require 'uni-input) RET > > If fact there are 10 files in lisp/leim/quail with provide forms. > > Out of these requiring one philippine, indonesian, indian, misc-lang and > emoji succeeds. > > While requiring one of uni-input, rfc1345, compose, pakistan or hangul > leads to an error. > > I don't know why this is the case. > >> Best regards, Michael. > > Rahguzar