From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Helmut Eller Newsgroups: gmane.emacs.devel Subject: Re: MPS prstack Date: Mon, 27 May 2024 09:27:31 +0200 Message-ID: <87le3vogt8.fsf@gmail.com> References: <87o790qsgm.fsf@gmail.com> <874jap95hi.fsf@gmail.com> <874janpa4m.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7837"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Emacs Devel To: Gerd =?utf-8?Q?M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 27 09:31:50 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBUpi-0001uf-9W for ged-emacs-devel@m.gmane-mx.org; Mon, 27 May 2024 09:31:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBUlt-0004hS-O9; Mon, 27 May 2024 03:27:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBUld-0004Nc-HC for emacs-devel@gnu.org; Mon, 27 May 2024 03:27:37 -0400 Original-Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBUlb-0006q2-Py; Mon, 27 May 2024 03:27:37 -0400 Original-Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4202ca70270so58242585e9.3; Mon, 27 May 2024 00:27:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716794853; x=1717399653; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PWh+/jZv+2HMNGhYpyuMRKH+oARU1ekECJs0oOQWJ00=; b=EZ0cK9T921Phi/ajvpZv35+iK9hdlVwIRahPa8ySo/g30kcovsT+BcRTK9bw7sLRKz 2O5IsTBcf0dgvG5S5fLiwOE9vQhDlMMucsvZkEIXis7ehPAV35zA7PyhmOH5EynNaztq be1iHgDNSKiauZlrUpfIv4TggmnGuO4DO9ZQL980WfujQt2Dk+vERHh7Et76aWWriER1 bN+X65UxEUHmCoJ1jIpenPgEWvsDd0o8jptED8FWQpwidnS40zaDXsee4Ss8mhkBXQvx 8IlcXa0QmFKX5FgoUE4OICYcJ7p+BWBFw8LDe9+FdmAK3nsrjO3s4FXmeA0dcQpWQexD 1adA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716794853; x=1717399653; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PWh+/jZv+2HMNGhYpyuMRKH+oARU1ekECJs0oOQWJ00=; b=n+CA4dnu/i/7lq0SODf0iMph1ZzsU3nE7kHIuS/LzXIsdAV+zKSSHIFfQI94Tw4zaO xEr+3sic88KL87CmLYWfE9l55v44h7qAb7n8ydW5wD9SkwDzFCnfrjBNJVfNgPgR/hZb tqQV7qBZNMrm8T+m731hDa7sVoT28FtOUgruB35DcIL5zccJn7E+lKQkGdKEZXT3FfGN fJKHf4bn8yiZIFMAjrMs0Bk0FD7/GN9ac8d2eSWom5TtGw+ezVIiUpmcB5vcjxVNrTti jFeiKJYrq6BWN4F7HCQ1d2RJx4zsHRjuN9lJBEpMn2USIMFrXOKqQ0kVHRdO8TuZzaFR kvgw== X-Forwarded-Encrypted: i=1; AJvYcCVVq/Au0HxwKXswRth/Mh9SFmfRvgZ8Bm4eJm0CZRL2XMObMXnfI+JNj0v/LKMihE1R5Lne4pAg9h+zp1oux+5TDtse X-Gm-Message-State: AOJu0YzBJrmoD3BVw+zTT7JNb7y5F/Q//dx2lIyiCOE+2TqU9dkx84JB L/cp5xrOv1LPq/Gx6sSlYKfOvsjE7Q6Cy1A3kHaxINuKF9t+GNqUzuO+nQ== X-Google-Smtp-Source: AGHT+IElBBFqh0D1JNJ/OtzclUx6QXH6AwrZXdrTJWNbnYYUQuHXobhQXXI1agrtYOgVwTf6Q53d3A== X-Received: by 2002:a05:6000:1284:b0:354:de28:9eb3 with SMTP id ffacd0b85a97d-3552211a448mr7195418f8f.0.1716794852973; Mon, 27 May 2024 00:27:32 -0700 (PDT) Original-Received: from caladan (dial-188233.pool.broadband44.net. [212.46.188.233]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626cc8b9b7sm459150466b.151.2024.05.27.00.27.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 00:27:32 -0700 (PDT) In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llman?= =?utf-8?Q?n=22's?= message of "Sat, 25 May 2024 15:45:29 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=eller.helmut@gmail.com; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319599 Archived-At: On Sat, May 25 2024, Gerd M=C3=B6llmann wrote: > Moint Helmut. I've pushed another fix that prevents processing non-Lisp > objs in sub char-tables. Oops. Would be nice if print-tests.el would cover some of the more exotic cases. Somewhat related: I wonder if this line in print_stack_push is safe: prstack.stack[prstack.sp++] =3D e; This is not an atomic operation and prstack.sp gets updated before the new stack slot is initialized. In theory, there is a small time window where scan_prstack can see the new prstack.sp but not the new value for the slot. Do we need to worry about such issues?