From: Ihor Radchenko <yantar92@posteo.net>
To: Robert Pluim <rpluim@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
kyle@kyleam.com, emacs-devel@gnu.org
Subject: Re: master 5a125fb5a97 1/2: Update to Org 9.7.3
Date: Fri, 14 Jun 2024 09:49:02 +0000 [thread overview]
Message-ID: <87le37onw1.fsf@localhost> (raw)
In-Reply-To: <878qzbbp75.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Tue, 11 Jun 2024 15:23:29 +0300, Eli Zaretskii <eliz@gnu.org> said:
> >> > Why does it want to read a file from my home directory as part of
> >> > building Emacs? That shouldn't happen.
> >>
> >> Agree. But I am unable to reproduce.
> >> Could you please provide more information?
>
> Removing "~/.emacs.d/.org-id-locations" is enough for me:
>
> org-id-locations-load()
> (if org-id-locations nil (org-id-locations-load))
> org-id-find-id-file("org-manual-get-export-props-customizations")
> org-babel-ref-goto-headline-id("org-manual-get-export-props-customizations")
> org-babel-expand-noweb-references(...)
This reveals a serious problem. Org indeed must not examine id db on the
build machine.
I installed the fix on Org side:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=13fdbf73f
However, this fix will only affect builds in Org git repo.
Please install the attached equivalent fix for Emacs makefiles.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Do-not-search-local-id-db-when-building-Org-mode-man.patch --]
[-- Type: text/x-patch, Size: 1531 bytes --]
From 5fefaad5b1c3ca4d10d3208e782596d79de8ca18 Mon Sep 17 00:00:00 2001
Message-ID: <5fefaad5b1c3ca4d10d3208e782596d79de8ca18.1718358372.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Fri, 14 Jun 2024 11:45:00 +0200
Subject: [PATCH] Do not search local id: db when building Org mode manual
* doc/misc/Makefile.in ($(1:.org=.texi)): Disable global id: database
when building Org manual. This prevents the build from reaching out to
local ID db on the build machine.
Reported-by: Eli Zaretskii <eliz@gnu.org>
Link: https://yhetil.org/emacs-devel/868qzd9hjg.fsf@gnu.org/
---
doc/misc/Makefile.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/misc/Makefile.in b/doc/misc/Makefile.in
index b26d3525a22..f1d03ff4b39 100644
--- a/doc/misc/Makefile.in
+++ b/doc/misc/Makefile.in
@@ -246,11 +246,14 @@ emacs =
# release tarfile along with the others.
# Work in srcdir (and use abs_top_builddir) so that +setupfile and
# things like org-setup's "version" macro work. Sigh.
+# Also, disable `org-id-track-globally' to make sure that link/target
+# resolution never ever tries to reach local user id: database.
define org_template
$(1:.org=.texi): $(1) ${top_srcdir}/lisp/org/ox-texinfo.el
$${AM_V_GEN}cd "$${srcdir}" && $${emacs} -l ox-texinfo \
--eval '(setq gc-cons-threshold 50000000)' \
--eval '(setq org-confirm-babel-evaluate nil)' \
+ --eval '(setq org-id-track-globally nil)' \
-f org-texinfo-export-to-texinfo-batch $$(notdir $$<) $$(notdir $$@)
endef
--
2.45.1
[-- Attachment #3: Type: text/plain, Size: 224 bytes --]
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-06-14 9:49 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171796793548.23337.12512115872160390161@vcs2.savannah.gnu.org>
[not found] ` <20240609211858.A2C31C1F9FB@vcs2.savannah.gnu.org>
2024-06-10 0:40 ` master 5a125fb5a97 1/2: Update to Org 9.7.3 Po Lu
2024-06-10 1:14 ` Kyle Meyer
2024-06-10 3:45 ` Po Lu
2024-06-10 3:58 ` Po Lu
2024-06-12 13:08 ` Ihor Radchenko
2024-06-12 13:13 ` Eli Zaretskii
2024-06-12 13:23 ` Ihor Radchenko
2024-06-12 13:30 ` Eli Zaretskii
2024-06-14 13:18 ` Ihor Radchenko
2024-06-10 11:13 ` Eli Zaretskii
2024-06-11 10:05 ` Ihor Radchenko
2024-06-11 12:23 ` Eli Zaretskii
2024-06-11 13:10 ` Robert Pluim
2024-06-14 9:49 ` Ihor Radchenko [this message]
2024-06-14 11:39 ` Eli Zaretskii
2024-06-14 12:02 ` Robert Pluim
2024-06-11 13:16 ` Stefan Monnier
2024-06-12 13:49 ` Ihor Radchenko
2024-06-12 14:41 ` Stefan Monnier
2024-06-13 13:00 ` Ihor Radchenko
2024-06-13 13:43 ` Eli Zaretskii
2024-06-13 14:34 ` Stefan Monnier
2024-06-14 12:39 ` Ihor Radchenko
2024-06-13 13:32 ` Ihor Radchenko
2024-06-13 13:54 ` Eli Zaretskii
2024-06-15 11:20 ` Ihor Radchenko
2024-06-15 12:46 ` Eli Zaretskii
2024-06-15 12:55 ` Syncing Org bugfix releases with emacs-30 branch (was: master 5a125fb5a97 1/2: Update to Org 9.7.3) Ihor Radchenko
2024-06-15 13:02 ` Eli Zaretskii
2024-06-16 11:09 ` Ihor Radchenko
2024-06-15 16:58 ` master 5a125fb5a97 1/2: Update to Org 9.7.3 Kyle Meyer
2024-06-11 11:03 ` Stefan Kangas
2024-06-12 3:45 ` Kyle Meyer
2024-06-12 8:52 ` Eli Zaretskii
2024-06-12 12:58 ` Ihor Radchenko
2024-06-12 13:02 ` Eli Zaretskii
2024-06-12 13:21 ` Ihor Radchenko
2024-06-12 13:29 ` Eli Zaretskii
2024-06-12 14:14 ` Stefan Kangas
2024-06-13 16:12 ` Ihor Radchenko
2024-06-13 16:48 ` Eli Zaretskii
2024-06-12 14:46 ` Stefan Monnier
2024-06-12 16:50 ` Eli Zaretskii
2024-06-13 15:44 ` Ihor Radchenko
2024-06-13 15:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le37onw1.fsf@localhost \
--to=yantar92@posteo.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kyle@kyleam.com \
--cc=monnier@iro.umontreal.ca \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).