From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: URGENT - which-key FSF contributor status Date: Tue, 18 Jun 2024 19:23:37 +0000 Message-ID: <87le32vyva.fsf@posteo.net> References: <87le4r98m9.fsf@jeremybryant.net> <86le4rjv9p.fsf@gnu.org> <87a5l78kc0.fsf@posteo.net> <87msp6o9o4.fsf@jeremybryant.net> <87sexelgnj.fsf@posteo.net> <86wmmqtmkl.fsf@gnu.org> <87wmmqmkh3.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24797"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , jb@jeremybryant.net, justin@burkett.cc, emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 18 21:24:43 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJeRd-0006Fi-LI for ged-emacs-devel@m.gmane-mx.org; Tue, 18 Jun 2024 21:24:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJeQn-0004cS-HH; Tue, 18 Jun 2024 15:23:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJeQk-0004c3-A6 for emacs-devel@gnu.org; Tue, 18 Jun 2024 15:23:46 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJeQh-0007Yd-SE for emacs-devel@gnu.org; Tue, 18 Jun 2024 15:23:45 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 49D6D240029 for ; Tue, 18 Jun 2024 21:23:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718738619; bh=ERpAir2ikub3vEOXJ0lI5FV8pqR5yrsn7iN6GQ3RP/o=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=AjVUwXN02O2nusqiGe2xsNwiipgg3NUthvmE58dvfy/bPHhgq23h9gqXek8MiQ4GY kXpVvJm1L5wCR9s7Zy/sCzBRh/hrNydCJcoSzWtXcmNzuCri8le1fUGuISmSgYiegP XPLRtCdIg2stAsssxsZIg0Y6XKQb1RuizOjmYeNOcO9D9r8BVYLMX6TOPLAHqmg0+7 fsSbW3Gbz/5sO47gaChTmMp04ih4o1Z+s+ADxEfq0CuSJVfLfWr2wXqGrwE+ZFHgaF 1aTAeWukpE9zvGeH2+0D4xBApGEo1J3SW4mb9zIXHacW5YW1rH/gRydWX1rs5mV/L8 8KD341r4/jPwA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W3c9k2j2Lz9rxP; Tue, 18 Jun 2024 21:23:37 +0200 (CEST) In-Reply-To: (Stefan Kangas's message of "Tue, 18 Jun 2024 15:06:22 -0400") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320263 Archived-At: --=-=-= Content-Type: text/plain Stefan Kangas writes: > Stefan Kangas writes: > >> Note these two warnings from package-lint when run on which-key.el: >> >> 806:0: error: "evil-state" doesn't start with package's prefix "which-key". >> 2334:10: error: `next-event' was removed in Emacs version 28.1. > > Did you have a chance to look into these warnings? Sorry, I forgot to respond to your message. > The first one seems cosmetic, but we might want to fix the second one > (assuming that it's a valid warning). The first one is related to evil-support I am not familiar with the issue to find a better solution. The second one is not a valid warning, apparently package-lint doesn't distinguish between function calls and variable bindings. If we really wanted to fix it, then --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/which-key.el b/lisp/which-key.el index 1de599e5497..8a61dd0edce 100644 --- a/lisp/which-key.el +++ b/lisp/which-key.el @@ -2336,9 +2336,9 @@ which-key-reload-key-sequence `which-key--current-key-list'. Any prefix arguments that were used are reapplied to the new key sequence." (let* ((key-seq (or key-seq (which-key--current-key-list))) - (next-event (mapcar (lambda (ev) (cons t ev)) key-seq))) + (next-evt (mapcar (lambda (ev) (cons t ev)) key-seq))) (setq prefix-arg current-prefix-arg - unread-command-events next-event))) + unread-command-events next-evt))) (defun which-key-turn-page (delta) "Show the next page of keys." --=-=-= Content-Type: text/plain would do it. -- Philip Kaludercic on peregrine --=-=-=--