Re: master 74bb1e5897f 2/3: Fix filling in c-ts-mode (bug#72116)

Re: master 74bb1e5897f 2/3: Fix filling in c-ts-mode (bug#72116)

[Andrea Corallo]

Yuan Fu <casouri@gmail.com> writes:

> branch: master
> commit 74bb1e5897f4532fbdefddada28258a8d3d5c95f
> Author: Yuan Fu <casouri@gmail.com>
> Commit: Yuan Fu <casouri@gmail.com>
>
>     Fix filling in c-ts-mode (bug#72116)
>
>     The previous fix introduced a regression in the case when there's only a
>     single line in the block comment.  In that case we don't want to add a
>     start at the second line:
>
>     /* foo foo foo */ should => /* foo foo
>                                    foo */
>
>     rather than   /* foo foo
>                    * foo */
>
>     This commit fixes that.
>
>     * lisp/progmodes/c-ts-common.el:
>     (c-ts-common--fill-block-comment): Don't mask the /*.
>     (c-ts-common--adaptive-fill-prefix): New function.
>     (c-ts-common-comment-setup): Don't set adaptive-regexp, change
>     adaptive-fill-first-line-regexp to work with the new
>     adaptive-fill-function.
>     * test/lisp/progmodes/c-ts-mode-resources/filling.erts: New tests

Hi Yuan,

this change is causing the following regression on my testbench on
master:

c-ts-mode-test-filling
1/4  c-ts-mode-test-filling (0.015896 sec) at lisp/progmodes/c-ts-mode-tests.el:38

Would you mind having a look?

Thanks

  Andrea

Re: master 74bb1e5897f 2/3: Fix filling in c-ts-mode (bug#72116)

[Yuan Fu]

> On Aug 1, 2024, at 1:53 AM, Andrea Corallo <acorallo@gnu.org> wrote:
> 
> Yuan Fu <casouri@gmail.com> writes:
> 
>> branch: master
>> commit 74bb1e5897f4532fbdefddada28258a8d3d5c95f
>> Author: Yuan Fu <casouri@gmail.com>
>> Commit: Yuan Fu <casouri@gmail.com>
>> 
>>    Fix filling in c-ts-mode (bug#72116)
>> 
>>    The previous fix introduced a regression in the case when there's only a
>>    single line in the block comment.  In that case we don't want to add a
>>    start at the second line:
>> 
>>    /* foo foo foo */ should => /* foo foo
>>                                   foo */
>> 
>>    rather than   /* foo foo
>>                   * foo */
>> 
>>    This commit fixes that.
>> 
>>    * lisp/progmodes/c-ts-common.el:
>>    (c-ts-common--fill-block-comment): Don't mask the /*.
>>    (c-ts-common--adaptive-fill-prefix): New function.
>>    (c-ts-common-comment-setup): Don't set adaptive-regexp, change
>>    adaptive-fill-first-line-regexp to work with the new
>>    adaptive-fill-function.
>>    * test/lisp/progmodes/c-ts-mode-resources/filling.erts: New tests
> 
> Hi Yuan,
> 
> this change is causing the following regression on my testbench on
> master:
> 
> c-ts-mode-test-filling
> 1/4  c-ts-mode-test-filling (0.015896 sec) at lisp/progmodes/c-ts-mode-tests.el:38
> 
> Would you mind having a look?
> 
> Thanks

Yes absolutely, wonder why it didn’t error when I wrote the patch :-(

Yuan

Re: master 74bb1e5897f 2/3: Fix filling in c-ts-mode (bug#72116)

[Yuan Fu]

> On Aug 3, 2024, at 12:30 AM, Yuan Fu <casouri@gmail.com> wrote:
> 
> 
> 
>> On Aug 1, 2024, at 1:53 AM, Andrea Corallo <acorallo@gnu.org> wrote:
>> 
>> Yuan Fu <casouri@gmail.com> writes:
>> 
>>> branch: master
>>> commit 74bb1e5897f4532fbdefddada28258a8d3d5c95f
>>> Author: Yuan Fu <casouri@gmail.com>
>>> Commit: Yuan Fu <casouri@gmail.com>
>>> 
>>>   Fix filling in c-ts-mode (bug#72116)
>>> 
>>>   The previous fix introduced a regression in the case when there's only a
>>>   single line in the block comment.  In that case we don't want to add a
>>>   start at the second line:
>>> 
>>>   /* foo foo foo */ should => /* foo foo
>>>                                  foo */
>>> 
>>>   rather than   /* foo foo
>>>                  * foo */
>>> 
>>>   This commit fixes that.
>>> 
>>>   * lisp/progmodes/c-ts-common.el:
>>>   (c-ts-common--fill-block-comment): Don't mask the /*.
>>>   (c-ts-common--adaptive-fill-prefix): New function.
>>>   (c-ts-common-comment-setup): Don't set adaptive-regexp, change
>>>   adaptive-fill-first-line-regexp to work with the new
>>>   adaptive-fill-function.
>>>   * test/lisp/progmodes/c-ts-mode-resources/filling.erts: New tests
>> 
>> Hi Yuan,
>> 
>> this change is causing the following regression on my testbench on
>> master:
>> 
>> c-ts-mode-test-filling
>> 1/4  c-ts-mode-test-filling (0.015896 sec) at lisp/progmodes/c-ts-mode-tests.el:38
>> 
>> Would you mind having a look?
>> 
>> Thanks
> 
> Yes absolutely, wonder why it didn’t error when I wrote the patch :-(

Ok, should be fixed now.

Yuan

Re: master 74bb1e5897f 2/3: Fix filling in c-ts-mode (bug#72116)

[Andrea Corallo]

Yuan Fu <casouri@gmail.com> writes:

>> On Aug 3, 2024, at 12:30 AM, Yuan Fu <casouri@gmail.com> wrote:
>> 
>> 
>> 
>>> On Aug 1, 2024, at 1:53 AM, Andrea Corallo <acorallo@gnu.org> wrote:
>>> 
>>> Yuan Fu <casouri@gmail.com> writes:
>>> 
>>>> branch: master
>>>> commit 74bb1e5897f4532fbdefddada28258a8d3d5c95f
>>>> Author: Yuan Fu <casouri@gmail.com>
>>>> Commit: Yuan Fu <casouri@gmail.com>
>>>> 
>>>>   Fix filling in c-ts-mode (bug#72116)
>>>> 
>>>>   The previous fix introduced a regression in the case when there's only a
>>>>   single line in the block comment.  In that case we don't want to add a
>>>>   start at the second line:
>>>> 
>>>>   /* foo foo foo */ should => /* foo foo
>>>>                                  foo */
>>>> 
>>>>   rather than   /* foo foo
>>>>                  * foo */
>>>> 
>>>>   This commit fixes that.
>>>> 
>>>>   * lisp/progmodes/c-ts-common.el:
>>>>   (c-ts-common--fill-block-comment): Don't mask the /*.
>>>>   (c-ts-common--adaptive-fill-prefix): New function.
>>>>   (c-ts-common-comment-setup): Don't set adaptive-regexp, change
>>>>   adaptive-fill-first-line-regexp to work with the new
>>>>   adaptive-fill-function.
>>>>   * test/lisp/progmodes/c-ts-mode-resources/filling.erts: New tests
>>> 
>>> Hi Yuan,
>>> 
>>> this change is causing the following regression on my testbench on
>>> master:
>>> 
>>> c-ts-mode-test-filling
>>> 1/4  c-ts-mode-test-filling (0.015896 sec) at lisp/progmodes/c-ts-mode-tests.el:38
>>> 
>>> Would you mind having a look?
>>> 
>>> Thanks
>> 
>> Yes absolutely, wonder why it didn’t error when I wrote the patch :-(
>
> Ok, should be fixed now.
>
> Yuan

Confirm thanks!

Re: master e4cd26defc0 1/3: "Separate" tree-sitter parser list for indirect buffers

[Michael Albinus]

Yuan Fu <casouri@gmail.com> writes:

Hi,

> branch: master
> commit e4cd26defc0e1a6deafbe4b2310ebdb3ffa4578f
> Author: Yuan Fu <casouri@gmail.com>
> Commit: Yuan Fu <casouri@gmail.com>
>
>     "Separate" tree-sitter parser list for indirect buffers

On emba.gnu.org, there is an error. See
<https://emba.gnu.org/emacs/emacs/-/jobs/89512/raw>.

--8<---------------cut here---------------start------------->8---
Test treesit-indirect-buffer backtrace:
  signal(ert-test-failed (((should (equal (list parser) (treesit-parse
  ert-fail(((should (equal (list parser) (treesit-parser-list))) :form
  #f(compiled-function () #<bytecode 0x11f4926225e9368d>)()
  #f(compiled-function () #<bytecode -0x1d83e15d7ee8c12f>)()
  handler-bind-1(#f(compiled-function () #<bytecode -0x1d83e15d7ee8c12
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name treesit-indirect-buffer :documentatio
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((and (not (or (tag :unstable) (tag :nativecomp))) (or
  ert-run-tests-batch((and (not (or (tag :unstable) (tag :nativecomp))
  ert-run-tests-batch-and-exit((and (not (or (tag :unstable) (tag :nat
  eval((ert-run-tests-batch-and-exit '(and (not (or (tag :unstable) (t
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
  command-line()
  normal-top-level()
Test treesit-indirect-buffer condition:
    (ert-test-failed
     ((should (equal (list parser) (treesit-parser-list))) :form
      (equal (#<treesit-parser for json>) nil) :value nil :explanation
      (different-types (#<treesit-parser for json>) nil)))
   FAILED   9/28  treesit-indirect-buffer (0.021114 sec) at src/treesit-tests.el:191
--8<---------------cut here---------------end--------------->8---

Best regatds, Michael.