From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: : : master 7f97cf31dc3: Create blessmail at build time instead of install time Date: Sun, 25 Aug 2024 05:10:52 +0000 Message-ID: <87le0l427a.fsf@protonmail.com> References: <172441424046.32730.1198862680597856819@vcs2.savannah.gnu.org> <20240823115720.C4A92C1FB72@vcs2.savannah.gnu.org> <87y14n77sd.fsf@protonmail.com> <87bk1js9gm.fsf@gmail.com> <87ttfb75oh.fsf@protonmail.com> <877cc7rzo7.fsf@gmail.com> <877cc65a55.fsf@protonmail.com> <87ed6d2u57.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30739"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Heerdegen To: "Michael Heerdegen via \"Emacs development discussions.\"" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 25 08:10:16 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1si6S5-0007mt-Pl for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Aug 2024 08:10:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1si6RT-0002Tc-Mh; Sun, 25 Aug 2024 02:09:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1si5Wq-0001Vb-9e for emacs-devel@gnu.org; Sun, 25 Aug 2024 01:11:04 -0400 Original-Received: from mail-40134.protonmail.ch ([185.70.40.134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1si5Wl-0000aJ-Il for emacs-devel@gnu.org; Sun, 25 Aug 2024 01:11:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1724562657; x=1724821857; bh=E5a1qCWAKC07Zw/G2wnyDDeajSq2RhIbZm2CfvCPSIA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ItFztKAG+MJMBbJOm10/Cn5kwE1DIUNR/ObJKEQPaVWpXk4LKquDjqms0kq1tby+m yBOsUIjo18OoDRLhWHGRNIwxn51tlSqo/DrozbJrHr+7xj1bB0EoNVh5PurdvQEcBW HJ599FZyeK+BIy2qVNuYHB5uD4hdkRixyt4Aj+spsqhU4eslw6nkw92tobYTOTuJzW cvN9NVRojQznFIaPSjuUmFkETNt+RoL9uftHH6QGIGfFHiktkSKj6HJPMby3W8LTu+ VYujmPkuT6QG6OQkA2IM8O48vfhCK4d8BYfraYGgb7ZddUSsog2uEVn6Vkf/p49jm1 0hKiUz7wNhkOg== In-Reply-To: <87ed6d2u57.fsf@web.de> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 3e904c086fa47189d7ee3b68bc68af12227b15cf Received-SPF: pass client-ip=185.70.40.134; envelope-from=pipcet@protonmail.com; helo=mail-40134.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 25 Aug 2024 02:09:34 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323116 Archived-At: "Michael Heerdegen via \"Emacs development discussions.\"" writes: > Pip Cet writes: > >> +(defun blessmail-command (string) >> + (if (and (boundp 'blessmail-doit) >> + blessmail-doit) >> + (shell-command string) >> + (message (concat " " string)))) > > Better (message "%s" ...) maybe? But my main point is: Yes, you're right. >> + (unless (=3D ?w (aref modes 8)) >> + (message (concat "Assuming %s is really the mail spool directory,= you should\n" >> + "run the following commands as root, to give %s= \n" >> + "appropriate permissions:\n") >> + dirname (file-name-nondirectory movemail-path)) >> + (cond >> + ((=3D ?w (aref modes 5)) >> +=09(blessmail-command >> + (concat "chgrp " (number-to-string (file-attribute-group-id at= tr)) >> +=09=09 " " movemail-path " && chmod g+s " movemail-path))) >> + ((=3D ?w (aref modes 2)) >> + (blessmail-command >> + (concat "chown " (number-to-string (file-attribute-user-id att= r)) >> +=09=09 " " movemail-path " && chmod u+s " movemail-path))) >> + (t >> + (blessmail-command >> + (concat "chown root " movemail-path " && chmod u+s " movemail-= path))))) >> + (message "\nDo that after running make install."))) >> (kill-emacs) > > Not an expert for shell stuff, but: wouldn't this cause trouble for > people using a non-posix compliant shell, like the popular fish shell? You mean because of the "&&"? That appears to work with a recent fish shell version, but I'm not sure about other shells people might use as their root shell. > AFAIU this will be called before the user can even set `shell-file-name'. I believe that's correct, but as the commands are only printed, so far, it's maybe less of a problem. With non-POSIX root shells, pretty much all bets are off, though, aren't they? It's not even clear sh -c 'chrgrp ... && chmod ...' would work? Pip