From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master c86e7a29e78: ; Fix documentation of last change Date: Thu, 26 Sep 2024 16:46:00 +0100 Message-ID: <87ldzeh0zr.fsf@melete.silentflame.com> References: <172734990367.10758.14920367247781455923@vcs2.savannah.gnu.org> <20240926112504.2BD9EC4110A@vcs2.savannah.gnu.org> <86y13ea601.fsf@gnu.org> <86msjua3v2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8670"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 26 17:46:53 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1stqhg-00024J-OK for ged-emacs-devel@m.gmane-mx.org; Thu, 26 Sep 2024 17:46:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stqh4-0005fY-SS; Thu, 26 Sep 2024 11:46:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stqh3-0005fE-3U for emacs-devel@gnu.org; Thu, 26 Sep 2024 11:46:13 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stqh1-0001Rn-OU for emacs-devel@gnu.org; Thu, 26 Sep 2024 11:46:12 -0400 DKIM-Signature: a=rsa-sha256; b=U6q0GYuX2LeS/Cc4nHEphYbakWwkTbP9PgWInqytZKfDOHavo7sOkGxDfmdQGqfZgiPYB3xkRlDY8PzBHX6U/AtP40xtW7hVY91xFI0b9dLz+jy0tybwd1UOYrZxnJhj2XJg15Zw0atmwrOFJOqjls9JuULZHASUqfNG8AKZFujyk4m0QyhPJ7ADuHJPZLRDIezbKMdC2nxm3fUGx0mgHhdx3nGKOjMj5tTuiDX08OmybgBDkpAXH4hj0gaRgfFMiFzYZBtryM9/DWw57/lzcFSIdVfvnUt3My34FSwRwI/s5KWY8eDM5VigGQzI/UZAK3zmoc+eAV5IORTKmj0taQ==; s=purelymail1; d=spwhitton.name; v=1; bh=Je6HrOhrxhNss/BUMlG+axyi4hQfC2jTyeJEaPNTJms=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=DfFpTMrbfVK/mewsMRjM2X02epU9UtKz+5BB/pPkExyIg/Yp3QYYAxu7T2krwLqH0zldbbWhIwNjn341emeIJ0q48CsHByOAHR7sYrjR40JI4KqGm025FJhyCrOrKNPGrAirzeE9HIY3pQckPoLFraA+3kpAQK/PDnWOOycSPd/jK731A3KPeHSCZemTRYWMCF5QLTav7dsWaziggCPjf8z2s+QKmsaYwNtas7q6RZZBIentjOTS7sjc4zRjlwXL4g4RX0qT2FgfnT0i5p3NHv2vLgjGxVesG6PudNSNqjBo4Tk/fCVWGEYq5bNbszD84TFawL0oH0NLO806vfFHKQ==; s=purelymail1; d=purelymail.com; v=1; bh=Je6HrOhrxhNss/BUMlG+axyi4hQfC2jTyeJEaPNTJms=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: emacs-devel@gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 715664412; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 26 Sep 2024 15:46:02 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 03A007E2045; Thu, 26 Sep 2024 16:46:00 +0100 (BST) In-Reply-To: <86msjua3v2.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 26 Sep 2024 17:25:53 +0300") Received-SPF: pass client-ip=34.202.193.197; envelope-from=spwhitton@spwhitton.name; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324112 Archived-At: Hello, On Thu 26 Sep 2024 at 05:25pm +03, Eli Zaretskii wrote: >> Right, but the two VCS commands I mention show uncommitted changes. > > Maybe by default, not in general. And there VC commands that show > committed changes, which can also be reverted by this new command, > right? Good points. > So maybe we should say "undo commits or changes". Well, it can only undo commits when they consist of exactly one hunk, so it would be misleading to say that it can undo commits in general. I think just "changes" covers both uncommitted and committed changes well, but we could have "undo uncommitted changes or revert committed changes" ? -- Sean Whitton