From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master c3e989ca9d7: New minor mode find-function-mode replaces find-function-setup-keys Date: Fri, 04 Oct 2024 20:47:14 +0800 Message-ID: <87ldz4xcfh.fsf@melete.silentflame.com> References: <172800172214.1813703.15067539931889719779@vcs3.savannah.gnu.org> <20241004002843.024A41867DE@vcs3.savannah.gnu.org> <87v7y8ywok.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12779"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 04 14:48:21 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1swhjJ-000392-JV for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Oct 2024 14:48:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swhiW-0006SX-Th; Fri, 04 Oct 2024 08:47:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swhiO-0006Qx-TO for emacs-devel@gnu.org; Fri, 04 Oct 2024 08:47:26 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swhiM-0005YS-NP for emacs-devel@gnu.org; Fri, 04 Oct 2024 08:47:24 -0400 DKIM-Signature: a=rsa-sha256; b=z56LBg0mBIJO3zPDVj7HtaRpkzMjNooQJSAOD+iH+inlqp30jkbe24JKv/s7d0CmDC7DSpsyY9hOua275lHB04Y4qUXTOBwscznAsfy6anSnhF74i8xPExtOsJB/Q+27FG2Ra6i8jws9QfqaWKc7PIKpQ+56TiSwVL2bwOEff4N/g1e0+vz8D6ALFuRg5sRLHcibhcSPsM3QvPkp6Nza1ePAe3tQnYPs2mPj6RmwTOhfViCiteVuL2hUV2GBS3Wa36CfaxAsQM/I0O8C5XNOD5Frd4DDmS8xJP/F5AVSv/bNbaHT70N2VEvHSIycxu3ZkogNrsqpcoLoN16BRFHmHw==; s=purelymail2; d=spwhitton.name; v=1; bh=ZQDLrE15K/uJh7iXpVijZtY22bM5TAI0GOyLwvcwrEQ=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=3UeJ2WzPe0rngWcSQotq3pmbxvqVtgbKR1574LMsQ+B6QqN41A4koQL2Wnn/Vb1t0GkC73AeLMDcESuiPDKe29k/NJ79nuJQvim1nwkhY2lMffWFx7bHz3E9BYzPUueGbRFeSfhJa9n2L9hH0Y+yard53x/P7sJ46QTd2KOh4nFzGEzb4CK1CmebIzarOtvIAw2n9HOS16YG4hHhusfNMtdd9T8YMxGDYLCqnxNeJxq3v016qxeLlmHSG+z3UCqiaSTI4DlhThQIOf0xWDBN8kCZmgNNUE9OY1aXPBve7dsB1kVhV46YloA7Ee1wedALAdZVEbBNwJdJ9tAPFTIkwQ==; s=purelymail2; d=purelymail.com; v=1; bh=ZQDLrE15K/uJh7iXpVijZtY22bM5TAI0GOyLwvcwrEQ=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: emacs-devel@gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1519007169; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 04 Oct 2024 12:47:17 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id CB7FC7E4B45; Fri, 4 Oct 2024 20:47:14 +0800 (CST) In-Reply-To: (Eshel Yaron's message of "Fri, 04 Oct 2024 13:57:00 +0200") Received-SPF: pass client-ip=34.202.193.197; envelope-from=spwhitton@spwhitton.name; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324315 Archived-At: Hello, On Fri 04 Oct 2024 at 01:57pm +02, Eshel Yaron wrote: > Sean Whitton writes: > >> On Fri 04 Oct 2024 at 11:56am +02, Eshel Yaron wrote: >> >>> Hmm this changes the precedence of these bindings from low (global map) >>> to very high (minor mode map). So it's actually quite a breaking change >>> for those of us that use find-function-setup-keys and override these >>> bindings in certain major mode maps :/ >>> >>> How about keeping the behavior of find-function-setup-keys as it was? >>> We can keep that minor mode too, of course. >> >> Ah, that was not intentional. Thanks for pointing this out. >> >> One option is just to keep find-function-setup-keys as it was. >> Another would be to make the minor mode add the keys to the global map, >> and remove them from it when deactivated. How about that? > > The first option might be slightly simpler, but either way works for my > use case, I think. I prefer the second, so installed that. -- Sean Whitton