From: Sean Whitton <spwhitton@spwhitton.name>
To: Eshel Yaron <me@eshelyaron.com>
Cc: emacs-devel@gnu.org
Subject: Re: master c3e989ca9d7: New minor mode find-function-mode replaces find-function-setup-keys
Date: Fri, 04 Oct 2024 20:47:14 +0800 [thread overview]
Message-ID: <87ldz4xcfh.fsf@melete.silentflame.com> (raw)
In-Reply-To: <m1frpcqdwz.fsf@dazzs-mbp.home> (Eshel Yaron's message of "Fri, 04 Oct 2024 13:57:00 +0200")
Hello,
On Fri 04 Oct 2024 at 01:57pm +02, Eshel Yaron wrote:
> Sean Whitton <spwhitton@spwhitton.name> writes:
>
>> On Fri 04 Oct 2024 at 11:56am +02, Eshel Yaron wrote:
>>
>>> Hmm this changes the precedence of these bindings from low (global map)
>>> to very high (minor mode map). So it's actually quite a breaking change
>>> for those of us that use find-function-setup-keys and override these
>>> bindings in certain major mode maps :/
>>>
>>> How about keeping the behavior of find-function-setup-keys as it was?
>>> We can keep that minor mode too, of course.
>>
>> Ah, that was not intentional. Thanks for pointing this out.
>>
>> One option is just to keep find-function-setup-keys as it was.
>> Another would be to make the minor mode add the keys to the global map,
>> and remove them from it when deactivated. How about that?
>
> The first option might be slightly simpler, but either way works for my
> use case, I think.
I prefer the second, so installed that.
--
Sean Whitton
next prev parent reply other threads:[~2024-10-04 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172800172214.1813703.15067539931889719779@vcs3.savannah.gnu.org>
[not found] ` <20241004002843.024A41867DE@vcs3.savannah.gnu.org>
2024-10-04 9:56 ` master c3e989ca9d7: New minor mode find-function-mode replaces find-function-setup-keys Eshel Yaron
2024-10-04 10:44 ` Sean Whitton
2024-10-04 11:57 ` Eshel Yaron
2024-10-04 12:47 ` Sean Whitton [this message]
2024-10-05 16:56 ` Howard Melman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldz4xcfh.fsf@melete.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=emacs-devel@gnu.org \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).