From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: having emacs-matlab in ELPA, finally. FSF paper signed Date: Sat, 23 Nov 2024 10:30:10 +0000 Message-ID: <87ldxansy5.fsf@posteo.net> References: <871q37um8q.fsf@mat.ucm.es> <87v80cp8nx.fsf@mat.ucm.es> <877ccmkmwy.fsf@posteo.net> <87bk1y0wcm.fsf@mat.ucm.es> <87o75xkjpj.fsf@posteo.net> <874j3z8cy5.fsf@mat.ucm.es> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10641"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrea Corallo , To: Uwe Brauer Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 23 11:31:09 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEnPx-0002ZS-14 for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Nov 2024 11:31:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEnPA-00022z-7m; Sat, 23 Nov 2024 05:30:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEnP6-00022S-JJ for emacs-devel@gnu.org; Sat, 23 Nov 2024 05:30:16 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEnP4-0000rl-9f for emacs-devel@gnu.org; Sat, 23 Nov 2024 05:30:16 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7F187240027 for ; Sat, 23 Nov 2024 11:30:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1732357812; bh=6FMs0Ycs30RWOOEetToY3El9zCE93ZMAZE8RODQYlYo=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=dc1D11ThQa75SeXzZGeEDpbW+bgSLrN7+NU+MGAHybhdkpxV/caXXF6Szm76LhhgT I6L6S2V+i//PITZEDxhbunhz7A1l+nyobLXMT+vfaUGW8lBHCndAIgTV/PdsUl1kji j7jMwA20AnEAULWiDhFmOEymLzB8Y5YNGF8YpIQGe+Y5ytE5GNsHRthGZzS6dgdxcs WuiRRQW+Jpi64Wj5HtGo4kZWH5rzs6cCE6vQ8r7Xh8ec1p5+665CGpdSeTBNEj09Wb K/ZkbTRj0Q4hn2NK6IO49iYy3IP35BWQa+JQByBpSpHHw1JJALWqW9p04vNvKOQj3C 0Z4cCZMtixSKA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XwSsH1g2qz9rxG; Sat, 23 Nov 2024 11:30:11 +0100 (CET) In-Reply-To: <874j3z8cy5.fsf@mat.ucm.es> (Uwe Brauer's message of "Fri, 22 Nov 2024 17:12:34 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325611 Archived-At: --=-=-= Content-Type: text/plain Uwe Brauer writes: > Hi > > >> Uwe Brauer writes: > >> OK, just ping me when you think the cleanup process is done, and I can >> tell you if anything remains to be done before adding the package. > > > Ok, we finished some weeks ago but also had to merge some branches with new features. > > I just recall that our repository now is in https://github.com/mathworks/Emacs-MATLAB-Mode.git > > And we have it also in MELPA. As we discussed I would like to have it in > ELPA (all authors signed the FSF papers). If it works as expected I > might remove it from MELPA. > The following two points are not entirely clear to me: > > 1. The version numbering and the commits we push. > > 1. In MELPA every commit we push, will result in an updated MELPA > version. There version scheme is like for example in our case. > matlab-mode 20241117.1628 > > 2. I see that ELPA has something like this > aggressive-indent 1.10.0 available gnu > aggressive-indent 20230112.1300 available melpa > so is the GNU/EPLA version identical to the MELPA one > > 2. The procedure for MELPA is as follows. > > 1. MELPA itself dwells in github, so > > 2. I need to fork that repository, clone it > > 3. Add a branch, > > 4. Add a recipe file that looks like > > (matlab-mode > :fetcher github > :repo "mathworks/Emacs-MATLAB-Mode" > :files (:defaults > ("toolbox" "toolbox/*.m") > ("toolbox/+emacs" "toolbox/+emacs/*.m") > ("toolbox/+emacs/@Breakpoints" "toolbox/+emacs/@Breakpoints/*.m") > ("toolbox/+emacs/@EmacsServer" "toolbox/+emacs/@EmacsServer/*.m") > ("toolbox/+emacs/@Stack" "toolbox/+emacs/@Stack/*.m") > ("bin" "bin/*.sh") > (:exclude "matlab-maint.el"))) > > 1. Commit and push > > 2. Open a pull-request. > > Now what is the procedure for ELPA, and is there anything like a recipe > file? You don't have to do anything*, I just have to add a package specification (similar to the "recipe file" for MELPA) to elpa.git. * As soon as it works. The main issues right now, are as you noticed that ELPA doesn't release a new tarball for every commit, but just when a new version is released. We track this by checking for commits that bump the "Version" header in the main file (in your case matlab.el). You currently don't have any version number, so the build fails. I would suggest applying a change like this, if it doesn't break any assumptions you have regarding the minimal Emacs version: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/matlab.el b/matlab.el index 8ca0ee24a2..b82229a672 100644 --- a/matlab.el +++ b/matlab.el @@ -5,11 +5,7 @@ ;; Maintainer: Eric M. Ludlam ;; Created: 04 Jan 91 ;; Keywords: MATLAB(R) -;; Version: - -(defconst matlab-mode-version "5.0" - "Current version of MATLAB(R) mode.") - +;; Version: 5.0 ;; ;; Copyright (C) 1997-2022 Eric M. Ludlam ;; Copyright (C) 1991-1997 Matthew R. Wette @@ -50,6 +46,10 @@ ;;; Code: +(defconst matlab-mode-version (package-get-version) + "Current version of MATLAB(R) mode.") + + (require 'matlab-compat) (require 'matlab-syntax) (require 'matlab-scan) --=-=-= Content-Type: text/plain The other issue is that ELPA checks the copyright string and wants to see that all packages in GNU ELPA have their copyright assigned to the FSF. If you can fix these two things, then everything should go through. You can then decide to filter out files out of the final tarball by adding an .elpaignore file that lists what files to exclude. > Thanks and regards > > Uwe Brauer --=-=-=--