From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: Please check-in Belanger's Calc patches Date: 20 Jul 2004 12:40:37 -0500 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: <87k6wyefvu.fsf@floss.red-bean.com> References: <87658qlgte.fsf@floss.red-bean.com> Reply-To: kfogel@red-bean.com NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1090369006 25953 80.91.224.253 (21 Jul 2004 00:16:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 21 Jul 2004 00:16:46 +0000 (UTC) Cc: Tacvek , Jay Belanger Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 21 02:16:34 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Bn4mf-00016e-00 for ; Wed, 21 Jul 2004 02:16:33 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bn4pP-0007h0-UW for ged-emacs-devel@m.gmane.org; Tue, 20 Jul 2004 20:19:23 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bn4pF-0007fo-6Z for emacs-devel@gnu.org; Tue, 20 Jul 2004 20:19:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bn4pC-0007fC-OC for emacs-devel@gnu.org; Tue, 20 Jul 2004 20:19:12 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bn4pC-0007f9-FR for emacs-devel@gnu.org; Tue, 20 Jul 2004 20:19:10 -0400 Original-Received: from [207.115.63.73] (helo=pimout5-ext.prodigy.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bn4m9-0004sn-H1 for emacs-devel@gnu.org; Tue, 20 Jul 2004 20:16:01 -0400 Original-Received: from floss.red-bean.com (adsl-65-42-95-177.dsl.chcgil.ameritech.net [65.42.95.177]) by pimout5-ext.prodigy.net (8.12.10 milter /8.12.10) with ESMTP id i6L0G04G206700; Tue, 20 Jul 2004 20:16:00 -0400 Original-Received: from kfogel by floss.red-bean.com with local (Exim 3.34 #1 (Debian)) id 1BmybW-0003UK-00; Tue, 20 Jul 2004 12:40:38 -0500 Original-To: emacs-devel@gnu.org Emacs: or perhaps you'd prefer Russian Roulette, after all? In-Reply-To: <87658qlgte.fsf@floss.red-bean.com> Original-Lines: 72 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25858 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25858 I wrote: > If the maintainer is not available, I'll take a look at this (I don't > know Calc either, but probably can learn enough to apply this patch). Jay, I took a look at your patch, and tested that it fixes the bug. I don't know how on earth you deduced the nature of the hitherto undefined variable `calc-mode-var-list' just from looking at the code, but nice job :-). The change is more than 10 lines, so the FSF needs to get copyright assignment papers from you. I trust that's okay? Somewhat to my surprise, the assignment forms do not appear to be online, so I'm going through the procedures described in http://www.gnu.org/prep/maintain_5.html#SEC5 to get you the forms. In the meantime, could you check over the following ChangeLog entry? I'm no expert in Calc, so might have failed to mention something important about the change. Also, if you wanted to write a doc string for the variable `calc-mode-var-list', that would be great (though certainly not necessary for checking in this change). Thanks, -Karl --------------------8-<-------cut-here---------8-<----------------------- 2004-07-20 Karl Fogel Apply Jay Belanger 's patch from http://lists.gnu.org/archive/html/emacs-devel/2003-10/msg00719.html. This fixes the bug described in http://lists.gnu.org/archive/html/emacs-devel/2004-02/msg00437.html, and was apparently approved by Calc's maintainer. See http://lists.gnu.org/archive/html/emacs-devel/2004-07/msg00316.html and the thread hanging therefrom for more information. * calc/calc.el (calc-mode-var-list): Define this variable. (calc-always-load-extensions, calc-line-numbering, calc-line-breaking, calc-display-just, calc-display-origin, calc-number-radix, calc-leading-zeros, calc-group-digits, calc-group-char, calc-point-char, calc-frac-format, calc-prefer-frac, calc-hms-format, calc-date-format, calc-float-format, calc-full-float-format, calc-complex-format, calc-complex-mode, calc-infinite-mode, calc-display-strings, calc-matrix-just, calc-break-vectors, calc-full-vectors, calc-full-trail-vectors, calc-vector-commas, calc-vector-brackets, calc-matrix-brackets, calc-language, calc-language-option, calc-left-label, calc-right-label, calc-word-size, calc-previous-modulo, calc-simplify-mode, calc-auto-recompute, calc-display-raw, calc-internal-prec, calc-angle-mode, calc-algebraic-mode, calc-incomplete-algebraic-mode, calc-symbolic-mode, calc-matrix-mode, calc-shift-prefix, calc-window-height, calc-display-trail, calc-show-selections, calc-use-selections, calc-assoc-selections, calc-display-working-message, calc-auto-why , calc-timing, calc-mode-save-mode, calc-standard-date-formats, calc-autorange-units, calc-was-keypad-mode, calc-full-mode, calc-user-parse-tables, calc-gnuplot-default-device, calc-gnuplot-default-output, calc-gnuplot-print-device, calc-gnuplot-print-output, calc-gnuplot-geometry, calc-graph-default-resolution, calc-graph-default-resolution-3d, calc-invocation-macro, calc-show-banner): Define these as part of `calc-mode-var-list's initialization, instead of using defvar. (calc-inverse-flag, calc-hyperbolic-flag, calc-keep-args-flag): Give doc strings to these variables. * calc/calc-embed.el (calc-embedded-set-modes): Use `calc-mode-var-list' correctly.