From: Karl Fogel <kfogel@floss.red-bean.com>
Cc: Tacvek <unknown_kev_cat@hotmail.com>, Jay Belanger <belanger@truman.edu>
Subject: Re: Please check-in Belanger's Calc patches
Date: 20 Jul 2004 12:40:37 -0500 [thread overview]
Message-ID: <87k6wyefvu.fsf@floss.red-bean.com> (raw)
In-Reply-To: <87658qlgte.fsf@floss.red-bean.com>
I wrote:
> If the maintainer is not available, I'll take a look at this (I don't
> know Calc either, but probably can learn enough to apply this patch).
Jay, I took a look at your patch, and tested that it fixes the bug. I
don't know how on earth you deduced the nature of the hitherto
undefined variable `calc-mode-var-list' just from looking at the code,
but nice job :-).
The change is more than 10 lines, so the FSF needs to get copyright
assignment papers from you. I trust that's okay? Somewhat to my
surprise, the assignment forms do not appear to be online, so I'm
going through the procedures described in
http://www.gnu.org/prep/maintain_5.html#SEC5
to get you the forms.
In the meantime, could you check over the following ChangeLog entry?
I'm no expert in Calc, so might have failed to mention something
important about the change. Also, if you wanted to write a doc string
for the variable `calc-mode-var-list', that would be great (though
certainly not necessary for checking in this change).
Thanks,
-Karl
--------------------8-<-------cut-here---------8-<-----------------------
2004-07-20 Karl Fogel <kfogel@red-bean.com>
Apply Jay Belanger <belanger@truman.edu>'s patch from
http://lists.gnu.org/archive/html/emacs-devel/2003-10/msg00719.html.
This fixes the bug described in
http://lists.gnu.org/archive/html/emacs-devel/2004-02/msg00437.html,
and was apparently approved by Calc's maintainer. See
http://lists.gnu.org/archive/html/emacs-devel/2004-07/msg00316.html
and the thread hanging therefrom for more information.
* calc/calc.el (calc-mode-var-list): Define this variable.
(calc-always-load-extensions, calc-line-numbering,
calc-line-breaking, calc-display-just, calc-display-origin,
calc-number-radix, calc-leading-zeros, calc-group-digits,
calc-group-char, calc-point-char, calc-frac-format,
calc-prefer-frac, calc-hms-format, calc-date-format,
calc-float-format, calc-full-float-format, calc-complex-format,
calc-complex-mode, calc-infinite-mode, calc-display-strings,
calc-matrix-just, calc-break-vectors, calc-full-vectors,
calc-full-trail-vectors, calc-vector-commas, calc-vector-brackets,
calc-matrix-brackets, calc-language, calc-language-option,
calc-left-label, calc-right-label, calc-word-size,
calc-previous-modulo, calc-simplify-mode, calc-auto-recompute,
calc-display-raw, calc-internal-prec, calc-angle-mode,
calc-algebraic-mode, calc-incomplete-algebraic-mode,
calc-symbolic-mode, calc-matrix-mode, calc-shift-prefix,
calc-window-height, calc-display-trail, calc-show-selections,
calc-use-selections, calc-assoc-selections,
calc-display-working-message, calc-auto-why , calc-timing,
calc-mode-save-mode, calc-standard-date-formats,
calc-autorange-units, calc-was-keypad-mode, calc-full-mode,
calc-user-parse-tables, calc-gnuplot-default-device,
calc-gnuplot-default-output, calc-gnuplot-print-device,
calc-gnuplot-print-output, calc-gnuplot-geometry,
calc-graph-default-resolution, calc-graph-default-resolution-3d,
calc-invocation-macro, calc-show-banner): Define these as part of
`calc-mode-var-list's initialization, instead of using defvar.
(calc-inverse-flag, calc-hyperbolic-flag, calc-keep-args-flag):
Give doc strings to these variables.
* calc/calc-embed.el (calc-embedded-set-modes): Use
`calc-mode-var-list' correctly.
next prev parent reply other threads:[~2004-07-20 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-13 16:09 Please check-in Belanger's Calc patches Tacvek
2004-07-13 17:42 ` Karl Fogel
2004-07-14 3:40 ` Jay Belanger
2004-07-14 18:27 ` Richard Stallman
2004-07-14 16:00 ` Karl Fogel
2004-07-20 17:40 ` Karl Fogel [this message]
2004-07-21 14:07 ` Stefan
2004-07-21 14:59 ` Jay Belanger
2004-07-21 15:44 ` Stefan Monnier
2004-07-21 17:16 ` Jay Belanger
2004-07-21 17:42 ` Jay Belanger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k6wyefvu.fsf@floss.red-bean.com \
--to=kfogel@floss.red-bean.com \
--cc=belanger@truman.edu \
--cc=kfogel@red-bean.com \
--cc=unknown_kev_cat@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).