From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stephen J. Turnbull" Newsgroups: gmane.emacs.devel,gmane.emacs.xemacs.beta Subject: Re: intern-soft, find-face/get-face, and facep for determining faces' definedness Date: Tue, 02 Nov 2004 15:14:08 +0900 Organization: The XEmacs Project Message-ID: <87k6t4rd5b.fsf@tleepslib.sk.tsukuba.ac.jp> References: <0whwtx5meng.fsf@rescomp.Stanford.EDU.i-did-not-set--mail-host-address--so-tickle-me> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1099376086 18615 80.91.229.6 (2 Nov 2004 06:14:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 2 Nov 2004 06:14:46 +0000 (UTC) Cc: xemacs-beta@xemacs.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 02 07:14:29 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1COrw5-0003Bv-00 for ; Tue, 02 Nov 2004 07:14:29 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1COs47-0006Ug-9z for ged-emacs-devel@m.gmane.org; Tue, 02 Nov 2004 01:22:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1COs3z-0006UR-Ee for emacs-devel@gnu.org; Tue, 02 Nov 2004 01:22:39 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1COs3y-0006Ty-VX for emacs-devel@gnu.org; Tue, 02 Nov 2004 01:22:39 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1COs3y-0006Ts-RG for emacs-devel@gnu.org; Tue, 02 Nov 2004 01:22:38 -0500 Original-Received: from [130.158.98.109] (helo=tleepslib.sk.tsukuba.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.34) id 1COrvr-0006Lu-Hq for emacs-devel@gnu.org; Tue, 02 Nov 2004 01:14:15 -0500 Original-Received: from steve by tleepslib.sk.tsukuba.ac.jp with local (Exim 3.36 #1 (Debian)) id 1COrvl-0007lY-00; Tue, 02 Nov 2004 15:14:09 +0900 Original-To: Brian Palmer In-Reply-To: <0whwtx5meng.fsf@rescomp.Stanford.EDU.i-did-not-set--mail-host-address--so-tickle-me> (Brian Palmer's message of "Mon, 01 Nov 2004 13:40:35 -0800") User-Agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.5 (chayote, linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29289 gmane.emacs.xemacs.beta:16641 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29289 >>>>> "Brian" == Brian Palmer writes: Brian> In vc.el, vc-annotate-lines, the following binding is established: Brian> (face (or (intern-soft face-name) [...] Brian> A fix would be in emacs to use (facep face-name) and [...] xemacs to use (find-face Brian> face-name), instead. This looks correct. Brian> Xemacs developers, is there any reason that xemacs's facep Brian> should not be extended to take either face objects or names Brian> (so, for example, (facep 'bold) => t )? Yes, there is. That's what `find-face' is for. We'd still probably want a way to distinguish between face names and face objects, and proving that (a) we don't currently have any code that depends on `facep''s behavior, and (b) that we'd never want it, is more work than this is worth. Brian> Or could find-face/get-face be implemented for emacs? (They Brian> seem like probably useful functions to me). Your version wasn't quite right; it's (defalias 'find-face 'facep) (defun get-face (face-or-name) (or (find-face face-or-name) (error "Face %s doesn't exist" face-or-name))) -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.