* Changes to th new GC percentage feature
@ 2005-07-29 18:51 Stefan Monnier
2005-07-30 3:34 ` Richard M. Stallman
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2005-07-29 18:51 UTC (permalink / raw)
Regardnig the change below:
2005-07-23 Richard M. Stallman <rms@gnu.org>
* insdel.c (syms_of_insdel): staticpro combine_after_change_buffer.
* bytecode.c (MAYBE_GC): Test gc_cons_threshold and
gc_relative_threshold, one by one.
* keyboard.c (read_char): Test gc_cons_threshold.
(syms_of_keyboard): staticpro Qecho_area_clear_hook.
* eval.c (Feval, Ffuncall): Test gc_cons_threshold and
gc_relative_threshold, one by one.
* alloc.c (gc_cons_threshold): Not static.
(gc_cons_combined_threshold): Var deleted.
(gc_relative_threshold): New variable.
(Fgarbage_collect, init_alloc_once): Compute gc_relative_threshold
instead of gc_cons_combined_threshold.
* lisp.h (gc_cons_threshold, gc_relative_threshold): Declare.
(gc_cons_combined_threshold): Declaration deleted.
what exactly is it trying to do? The only changes I can notice are:
- the bytecode interpreter and the eval and funcall functions now check two
values rather than one, thus being slower.
- read_char tests gc_cons_threshold.
I'm obviously missing something. Any hint?
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Changes to th new GC percentage feature
2005-07-29 18:51 Changes to th new GC percentage feature Stefan Monnier
@ 2005-07-30 3:34 ` Richard M. Stallman
2005-07-31 15:28 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Richard M. Stallman @ 2005-07-30 3:34 UTC (permalink / raw)
Cc: emacs-devel
what exactly is it trying to do? The only changes I can notice are:
- the bytecode interpreter and the eval and funcall functions now check two
values rather than one, thus being slower.
- read_char tests gc_cons_threshold.
There is code that temporarily changes gc_cons_threshold to prevent
GC from occurring. It was broken and caused an infinite recursion.
I think this is the clean fix.
The slowdown is surely insignificant.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Changes to th new GC percentage feature
2005-07-30 3:34 ` Richard M. Stallman
@ 2005-07-31 15:28 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2005-07-31 15:28 UTC (permalink / raw)
Cc: emacs-devel
> what exactly is it trying to do? The only changes I can notice are:
> - the bytecode interpreter and the eval and funcall functions now
> check two values rather than one, thus being slower.
> - read_char tests gc_cons_threshold.
> There is code that temporarily changes gc_cons_threshold to prevent
> GC from occurring. It was broken and caused an infinite recursion.
I thought I had carefully updated it to change
gc_cons_combined_threshold instead.
> I think this is the clean fix.
OK.
> The slowdown is surely insignificant.
I'd expect it to be measurable since it's executed at the very least least
once per iteration of any loop.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-07-31 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-29 18:51 Changes to th new GC percentage feature Stefan Monnier
2005-07-30 3:34 ` Richard M. Stallman
2005-07-31 15:28 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).