From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bill Wohler Newsgroups: gmane.emacs.devel Subject: Re: Icon update Date: Thu, 30 Mar 2006 17:52:54 -0800 Organization: Newt Software Message-ID: <87k6abtm6h.fsf@olgas.newt.com> References: <2014.1143413876@olgas.newt.com> <2055.1143413986@olgas.newt.com> <858xqvek7c.fsf@lola.goethe.zz> <4428D8BB.8050701@swipnet.se> <442A5D49.1000302@swipnet.se> <442B8350.3050902@swipnet.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1143770032 1419 80.91.229.2 (31 Mar 2006 01:53:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 31 Mar 2006 01:53:52 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 31 03:53:45 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FP8pU-0005AV-8G for ged-emacs-devel@m.gmane.org; Fri, 31 Mar 2006 03:53:36 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FP8pT-00077L-Gd for ged-emacs-devel@m.gmane.org; Thu, 30 Mar 2006 20:53:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FP8pH-00075H-JY for emacs-devel@gnu.org; Thu, 30 Mar 2006 20:53:23 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FP8pF-00071y-TT for emacs-devel@gnu.org; Thu, 30 Mar 2006 20:53:23 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FP8pF-00071p-M3 for emacs-devel@gnu.org; Thu, 30 Mar 2006 20:53:21 -0500 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FP8rX-0001S8-ME for emacs-devel@gnu.org; Thu, 30 Mar 2006 20:55:43 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1FP8oy-00056s-Tk for emacs-devel@gnu.org; Fri, 31 Mar 2006 03:53:05 +0200 Original-Received: from h-68-166-37-206.snvacaid.dynamic.covad.net ([68.166.37.206]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 31 Mar 2006 03:53:04 +0200 Original-Received: from wohler by h-68-166-37-206.snvacaid.dynamic.covad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 31 Mar 2006 03:53:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 37 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: h-68-166-37-206.snvacaid.dynamic.covad.net User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:onfe4XKMlJOCkPdNKQSmGxydgyg= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52238 Archived-At: Leon writes: > Handling icons is more complicated in emacs than in anything > else. Maybe some gtk programmers can point out a solution or maybe we > can create a set of universal icons like nvu and openoffice. We can > also publish a guideline of creating icons for emacs so that package > writers can follow. And in the end emacs will have a consistent look! I think Emacs doesn't have any special icon needs so that might not be necessary. Using the icons from the current theme is the best choice. Remember that Emacs also has to provide icons where GTK does not exist. Or GNOME. But it's fair to say that most Emacs users have it as an environment which is why the fallback, built-in icons, come from those icon sets. But you did remind me of something we should think about. I noticed that Jan's patch calls for the addition of properties to calls of tool-bar-add-item-from-menu such as (tool-bar-local-item-from-menu 'Info-search "search" map Info-mode-map :stock "gtk-find") This means that all calls to tool-bar-* in all modes to need to be updated. It would be good to avoid this. Plus, this approach doesn't scale to other systems. I think it would be preferable to keep the tool-bar-* calls the way they are and provide a table of Emacs icon names to the icon name for the system being used. That way, Emacs will honor the user's theme whether it is being run under GNOME, KDE, or Windows, without requiring code changes from all Emacs package developers. -- Bill Wohler http://www.newt.com/wohler/ GnuPG ID:610BD9AD Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian! If you're passed on the right, you're in the wrong lane.