From: michael.cadilhac@lrde.org (Michaël Cadilhac)
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: [Proposal] M-x tabify to indent only when needed.
Date: Tue, 25 Jul 2006 16:09:57 +0200 [thread overview]
Message-ID: <87k661ydvu.fsf@lrde.org> (raw)
In-Reply-To: <jwvveplvlgh.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 25 Jul 2006 09:55:34 -0400")
[-- Attachment #1.1: Type: text/plain, Size: 1185 bytes --]
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> + (if (= (/ end-col tab-width) (/ beg-col tab-width))
>> + ;; The spacing does not straddle a TAB boundary, so we won't
>> + ;; be able to use a TAB here anyway: there's nothing to do.
>> + nil
>
>> This detects a case where no tabs can be used.
>> It doesn't detect the case where tabs already ARE used.
>
> Those cases aren't matched by the regexp.
>
>> -(defvar tabify-regexp "[ \t][ \t]+"
>> +(defvar tabify-regexp " [ \t]+"
>
>> Is that change supposed to exclude those other cases?
>
> Exactly.
>
> Stefan
IIUC, your patch does work and is very much clearer than mine.
However, it suffers from the same precondition on tabify-regexp, which
should be described in its docstring.
Thanks!
--
| Michaël `Micha' Cadilhac | Si les religions etaient aussi tole- |
| Epita/LRDE Promo 2007 | rantes qu'elles le pretendent, il y |
| http://www.lrde.org/~cadilh_m | a longtemps qu'il n'y en aurait plus |
`-- - JID: micha@amessage.be --' -- Moustic - --'
[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]
[-- Attachment #2: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2006-07-25 14:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-24 17:30 [Proposal] M-x tabify to indent only when needed Michaël Cadilhac
2006-07-24 20:40 ` Michaël Cadilhac
2006-07-24 21:30 ` Stefan Monnier
2006-07-25 3:09 ` Richard Stallman
2006-07-25 13:55 ` Stefan Monnier
2006-07-25 14:09 ` Michaël Cadilhac [this message]
2006-07-25 15:07 ` Stefan Monnier
2006-07-25 15:28 ` Michaël Cadilhac
2006-07-25 16:21 ` Stefan Monnier
2006-07-25 17:09 ` Michaël Cadilhac
2006-07-24 21:50 ` Richard Stallman
2006-07-25 11:38 ` Michaël Cadilhac
2006-07-25 22:15 ` Richard Stallman
2006-07-26 11:29 ` Michaël Cadilhac
2006-07-26 11:32 ` Michaël Cadilhac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k661ydvu.fsf@lrde.org \
--to=michael.cadilhac@lrde.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).