From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.emacs.devel Subject: Re: fix the sscanf usage in etags Date: Thu, 10 Aug 2006 10:15:12 +1000 Message-ID: <87k65ho38v.fsf@zip.com.au> References: <20060807.123850.192456906.jet@gyve.org> <87psfa93i7.fsf@zip.com.au> <44D9874B.3040206@swipnet.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1155168957 15271 80.91.229.2 (10 Aug 2006 00:15:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 10 Aug 2006 00:15:57 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 10 02:15:54 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GAyDF-0005nZ-LI for ged-emacs-devel@m.gmane.org; Thu, 10 Aug 2006 02:15:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GAyDE-0002uQ-Vr for ged-emacs-devel@m.gmane.org; Wed, 09 Aug 2006 20:15:49 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GAyD2-0002uB-M2 for emacs-devel@gnu.org; Wed, 09 Aug 2006 20:15:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GAyD0-0002tz-HQ for emacs-devel@gnu.org; Wed, 09 Aug 2006 20:15:35 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GAyD0-0002tw-Bm for emacs-devel@gnu.org; Wed, 09 Aug 2006 20:15:34 -0400 Original-Received: from [61.8.0.84] (helo=mailout1.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GAyHn-0005t7-DH for emacs-devel@gnu.org; Wed, 09 Aug 2006 20:20:31 -0400 Original-Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout1.pacific.net.au (Postfix) with ESMTP id 744955A7F99 for ; Thu, 10 Aug 2006 10:15:29 +1000 (EST) Original-Received: from localhost (ppp2F59.dyn.pacific.net.au [61.8.47.89]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k7A0FSj2029846 for ; Thu, 10 Aug 2006 10:15:28 +1000 Original-Received: from gg by localhost with local (Exim 3.36 #1 (Debian)) id 1GAyCf-0003NE-00; Thu, 10 Aug 2006 10:15:13 +1000 Original-To: emacs-devel@gnu.org In-Reply-To: <44D9874B.3040206@swipnet.se> (Jan =?iso-8859-1?Q?Dj=E4rv's?= message of "Wed, 09 Aug 2006 08:57:15 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:58239 Archived-At: Masatake YAMATO writes: > > The problem I found was that etags crashed when `#line 123 L"wide"' was g= iven > as input. If the crashing can be suppressed, it is enough. That's the only bad case, you don't have some strange libc that incorrectly counts %n? Jan Dj=E4rv writes: > > if (sscanf (lbp->buffer, "#line %d %n\"", &lno, &start) >=3D 1 > && lbp->buffer[start] =3D=3D '"') I think that still uses start uninitialized on say "#line 123 ". I'd suggest (untested) something like start =3D -1; if (sscanf (lbp->buffer, "#line %d \"%n", &lno, &start) =3D=3D 1 && start !=3D -1) ...