From: Kevin Ryde <user42@zip.com.au>
Subject: Re: fix the sscanf usage in etags
Date: Thu, 10 Aug 2006 10:15:12 +1000 [thread overview]
Message-ID: <87k65ho38v.fsf@zip.com.au> (raw)
In-Reply-To: <44D9874B.3040206@swipnet.se> (Jan Djärv's message of "Wed, 09 Aug 2006 08:57:15 +0200")
Masatake YAMATO <jet@gyve.org> writes:
>
> The problem I found was that etags crashed when `#line 123 L"wide"' was given
> as input. If the crashing can be suppressed, it is enough.
That's the only bad case, you don't have some strange libc that
incorrectly counts %n?
Jan Djärv <jan.h.d@swipnet.se> writes:
>
> if (sscanf (lbp->buffer, "#line %d %n\"", &lno, &start) >= 1
> && lbp->buffer[start] == '"')
I think that still uses start uninitialized on say "#line 123 ". I'd
suggest (untested) something like
start = -1;
if (sscanf (lbp->buffer, "#line %d \"%n", &lno, &start) == 1
&& start != -1)
...
next prev parent reply other threads:[~2006-08-10 0:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 3:38 fix the sscanf usage in etags Masatake YAMATO
2006-08-08 9:35 ` Jan Djärv
2006-08-09 0:06 ` Kevin Ryde
2006-08-09 6:57 ` Jan Djärv
2006-08-09 7:57 ` Masatake YAMATO
2006-08-09 13:20 ` Jan Djärv
2006-08-09 14:10 ` Masatake YAMATO
2006-08-10 0:15 ` Kevin Ryde [this message]
2006-08-10 6:47 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k65ho38v.fsf@zip.com.au \
--to=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).