From: michael.cadilhac@lrde.org (Michaël Cadilhac)
Subject: ucs input method bug.
Date: Thu, 07 Sep 2006 13:31:31 +0200 [thread overview]
Message-ID: <87k64frjzg.fsf@lrde.org> (raw)
[-- Attachment #1.1.1: Type: text/plain, Size: 275 bytes --]
Test case:
emacs -Q
M-x set-input-method RET ucs RET
Type « ut » it will produce « tut ».
IMO, ucs strives to be Emacs by doing the command of the faulty
(unexpected) key (here « t ») while it is not needed.
I propose just to remove the part that does that.
[-- Attachment #1.1.2: uni-input.patch --]
[-- Type: text/x-patch, Size: 1362 bytes --]
Index: leim/quail/uni-input.el
===================================================================
RCS file: /sources/emacs/emacs/leim/quail/uni-input.el,v
retrieving revision 1.11
diff -c -r1.11 uni-input.el
*** leim/quail/uni-input.el 20 Apr 2006 08:38:14 -0000 1.11
--- leim/quail/uni-input.el 7 Sep 2006 11:25:07 -0000
***************
*** 100,110 ****
(progn
(push key events)
(ucs-input-insert-char key))
- (let ((last-command-char key)
- (current-prefix-arg))
- (condition-case err
- (call-interactively (key-binding seq))
- (quail-error (message "%s" (cdr err)) (beep))))
(quail-delete-region)
(throw 'non-digit (append (reverse events)
(listify-key-sequence seq))))))
--- 100,105 ----
Index: leim/ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/leim/ChangeLog,v
retrieving revision 1.193
diff -c -0 -r1.193 ChangeLog
*** leim/ChangeLog 12 Jul 2006 00:33:19 -0000 1.193
--- leim/ChangeLog 7 Sep 2006 11:25:15 -0000
***************
*** 0 ****
--- 1,6 ----
+ 2006-09-06 Michaël Cadilhac <michael.cadilhac@lrde.org>
+
+ * quail/uni-input.el (ucs-input-method): Don't make the action of
+ a key not in [0-9a-zA-Z] when it was expected to be. Let the Emacs
+ mechanism do it.
+
[-- Attachment #1.1.3: Type: text/plain, Size: 529 bytes --]
(Note: ucs input method triggered the bug I proposed to fix in the
thread « The order input events are processed. » : just type « uabt »
in a flyspell-ized buffer, and it will introduce the bug.)
--
| Michaël `Micha' Cadilhac | Un certain Blaise Pascal |
| Epita/LRDE Promo 2007 | etc... etc... |
| http://www.lrde.org/~cadilh_m | -- Prévert (Les paris stupides) |
`-- - JID: micha@amessage.be --' - --'
[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]
[-- Attachment #2: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next reply other threads:[~2006-09-07 11:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-07 11:31 Michaël Cadilhac [this message]
2006-09-14 2:46 ` ucs input method bug Kenichi Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k64frjzg.fsf@lrde.org \
--to=michael.cadilhac@lrde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).