From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Chong Yidong <cyd@stupidchicken.com>
Newsgroups: gmane.emacs.devel
Subject: Re: Flickering mouse-face
Date: Sun, 21 Jan 2007 18:35:08 -0500
Message-ID: <87k5zgc5sj.fsf@stupidchicken.com>
References: <17843.21733.348611.691384@kahikatea.snap.net.nz>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: sea.gmane.org 1169422525 20370 80.91.229.12 (21 Jan 2007 23:35:25 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Sun, 21 Jan 2007 23:35:25 +0000 (UTC)
Cc: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 22 00:35:24 2007
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1H8mDS-0001lW-Dv
	for ged-emacs-devel@m.gmane.org; Mon, 22 Jan 2007 00:35:14 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1H8mDR-0005gQ-VR
	for ged-emacs-devel@m.gmane.org; Sun, 21 Jan 2007 18:35:14 -0500
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1H8mDG-0005fd-Ny
	for emacs-devel@gnu.org; Sun, 21 Jan 2007 18:35:02 -0500
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1H8mDG-0005eg-7Z
	for emacs-devel@gnu.org; Sun, 21 Jan 2007 18:35:02 -0500
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1H8mDF-0005eQ-Ux
	for emacs-devel@gnu.org; Sun, 21 Jan 2007 18:35:01 -0500
Original-Received: from [18.19.1.138] (helo=cyd.mit.edu)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1H8mDF-0004ci-Ll
	for emacs-devel@gnu.org; Sun, 21 Jan 2007 18:35:01 -0500
Original-Received: by cyd.mit.edu (Postfix, from userid 1000)
	id 256D94E44F; Sun, 21 Jan 2007 18:35:08 -0500 (EST)
Original-To: Nick Roberts <nickrob@snap.net.nz>, Stephen Berman <Stephen.Berman@gmx.net>
In-Reply-To: <17843.21733.348611.691384@kahikatea.snap.net.nz> (Nick Roberts's
	message of "Mon\, 22 Jan 2007 00\:56\:21 +1300")
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.92 (gnu/linux)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:65358
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/65358>

OK, I've found and checked in the correct fix for the bug.  I also
reverted my original, deeply flawed fix.

FWIW, the original bug was caused by a 2006-09-17 change to dispnew.c
to avoid redrawing a whole row if it has mouse-face in it.  The
rationale for this change was that this was causing excessive
flickering of mode lines.  So I've made it so that we redraw a row if
it has mouse-face in it, except if it's a mode line.

Thanks for the feedback, and sorry for the false start in fixing this
bug.