From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Faces applies to new frames Date: Sun, 29 Jun 2008 15:24:44 -0400 Message-ID: <87k5g8t56r.fsf@stupidchicken.com> References: <87k5gbx12n.fsf@stupidchicken.com> <87iqvty2e7.fsf@stupidchicken.com> <871w2hcek1.fsf@stupidchicken.com> <87wsk8kgm5.fsf@stupidchicken.com> <87prq0z2jd.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1214767798 22652 80.91.229.12 (29 Jun 2008 19:29:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 Jun 2008 19:29:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 29 21:30:44 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KD2bd-0002y8-6z for ged-emacs-devel@m.gmane.org; Sun, 29 Jun 2008 21:30:37 +0200 Original-Received: from localhost ([127.0.0.1]:34485 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KD2an-0003Y8-0a for ged-emacs-devel@m.gmane.org; Sun, 29 Jun 2008 15:29:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KD2ai-0003XZ-MF for emacs-devel@gnu.org; Sun, 29 Jun 2008 15:29:40 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KD2ag-0003XF-GD for emacs-devel@gnu.org; Sun, 29 Jun 2008 15:29:39 -0400 Original-Received: from [199.232.76.173] (port=45118 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KD2ag-0003XC-Ce for emacs-devel@gnu.org; Sun, 29 Jun 2008 15:29:38 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]:35016) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KD2ag-0001Nl-AV for emacs-devel@gnu.org; Sun, 29 Jun 2008 15:29:38 -0400 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id E523C4E47B; Sun, 29 Jun 2008 15:24:44 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Sun, 29 Jun 2008 14:00:46 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100157 Archived-At: Stefan Monnier writes: > Yes, it makes a bit more sense, except that now I wonder why this > code would be needed at all? Isn't the `font' frame-parameter > automatically always kept up-to-date with the font of the > `default' face? If not, I think it should, and hence it should be done > elsewhere so that it's also true when we later change the default face > via `set-face-attributes' or something like that. This is because internal-merge-in-global-face (which is called in the middle of face-set-after-frame-default) merges in the face vector from face-new-frame-defaults without updating the `font' frame parameter. Every other place that changes the font uses set-face-attribute, which updates the `font' parameter correctly. I suppose we could change internal-merge-in-global-face to update the frame parameters itself, instead of adding a separate line in faces.el to do it.