From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: improve vc-bzr-print-log Date: Thu, 13 Aug 2009 13:28:37 -0400 Message-ID: <87k51762t6.fsf@stupidchicken.com> References: <200907261728.n6QHSNCP010388@godzilla.ics.uci.edu> <87y6qbutg4.fsf@stupidchicken.com> <200907262155.n6QLtQk4013442@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1250184591 12251 80.91.229.12 (13 Aug 2009 17:29:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Aug 2009 17:29:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 13 19:29:44 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mbe7T-0001WE-GE for ged-emacs-devel@m.gmane.org; Thu, 13 Aug 2009 19:29:43 +0200 Original-Received: from localhost ([127.0.0.1]:49220 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mbe7S-0001f7-OW for ged-emacs-devel@m.gmane.org; Thu, 13 Aug 2009 13:29:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mbe6Y-0001Ed-5o for emacs-devel@gnu.org; Thu, 13 Aug 2009 13:28:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mbe6S-0001BO-Kx for emacs-devel@gnu.org; Thu, 13 Aug 2009 13:28:44 -0400 Original-Received: from [199.232.76.173] (port=58714 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mbe6S-0001BD-Fi for emacs-devel@gnu.org; Thu, 13 Aug 2009 13:28:40 -0400 Original-Received: from pantheon-po33.its.yale.edu ([130.132.50.94]:43855) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mbe6S-0005YT-5G for emacs-devel@gnu.org; Thu, 13 Aug 2009 13:28:40 -0400 Original-Received: from furry (dhcp128036014244.central.yale.edu [128.36.14.244]) (authenticated bits=0) by pantheon-po33.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n7DHSbGP009405 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 13 Aug 2009 13:28:37 -0400 Original-Received: by furry (Postfix, from userid 1000) id 991F3C070; Thu, 13 Aug 2009 13:28:37 -0400 (EDT) In-Reply-To: <200907262155.n6QLtQk4013442@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 26 Jul 2009 14:55:26 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:114192 Archived-At: Dan Nicolaescu writes: > Chong Yidong writes: > > > Dan Nicolaescu writes: > > > > > When vc-bzr was written "bzr log" did not take multiple file arguments, > > > it does now, so vc-bzr-print-log can take advantage of this. > > > > > > Any objection to this patch? > > > > How old are the versions of bzr that don't accept multiple file > > arguments, > > No idea, I only have access to bzr-1.16.1. > > > and what effect does this change have on those versions? > > Doing C-x v l when multiple files are selected in vc-dir will not work. > C-x v l from a file context will work just the same. > The thing is that bzr users have all the reasons to use very up to date > versions, the performance and disk usage is dramatically better. > C-x v l for multiple files is new in 23.1, so not supporting it for old > bzr versions in 23.2 does not seem like a problem. Sorry for coming back to this so late. Could you add a defcustom to toggle between this new code (giving multiple file arguments to "bzr log") and the old code, defaulting to the new code? I don't think it's worth trying to autodetect bzr version, but let's at least give users a way to get the old behavior if they need it.