unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: Re: improve vc-bzr-print-log
Date: Thu, 13 Aug 2009 13:28:37 -0400	[thread overview]
Message-ID: <87k51762t6.fsf@stupidchicken.com> (raw)
In-Reply-To: <200907262155.n6QLtQk4013442@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 26 Jul 2009 14:55:26 -0700 (PDT)")

Dan Nicolaescu <dann@ics.uci.edu> writes:

> Chong Yidong <cyd@stupidchicken.com> writes:
>
>   > Dan Nicolaescu <dann@ics.uci.edu> writes:
>   > 
>   > > When vc-bzr was written "bzr log" did not take multiple file arguments,
>   > > it does now, so vc-bzr-print-log can take advantage of this.
>   > >
>   > > Any objection to this patch?
>   > 
>   > How old are the versions of bzr that don't accept multiple file
>   > arguments, 
>
> No idea, I only have access to  bzr-1.16.1.
>
>   > and what effect does this change have on those versions?
>
> Doing C-x v l when multiple files are selected in vc-dir will not work.
> C-x v l from a file context will work just the same.
> The thing is that bzr users have all the reasons to use very up to date
> versions, the performance and disk usage is dramatically better.
> C-x v l for multiple files is new in 23.1, so not supporting it for old
> bzr versions in 23.2 does not seem like a problem.

Sorry for coming back to this so late.

Could you add a defcustom to toggle between this new code (giving
multiple file arguments to "bzr log") and the old code, defaulting to
the new code?  I don't think it's worth trying to autodetect bzr
version, but let's at least give users a way to get the old behavior if
they need it.




  parent reply	other threads:[~2009-08-13 17:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-26 17:28 improve vc-bzr-print-log Dan Nicolaescu
2009-07-26 19:37 ` Chong Yidong
2009-07-26 21:55   ` Dan Nicolaescu
2009-07-27  1:54     ` Stephen J. Turnbull
2009-08-13 17:28     ` Chong Yidong [this message]
2009-08-13 17:40       ` Dan Nicolaescu
2009-07-27  2:50 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k51762t6.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).