From: Juri Linkov <juri@jurta.org>
To: emacs-devel@gnu.org
Subject: Re: file local variables
Date: Tue, 15 Dec 2009 02:20:00 +0200 [thread overview]
Message-ID: <87k4wpyrbv.fsf@mail.jurta.org> (raw)
In-Reply-To: <87ljh53z37.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 15 Dec 2009 01:39:12 +0200")
>> BTW, while looking at this bug, I noticed a security hole in using
>> duplicate file local variables.
>>
>> `hack-local-variables-filter' checks for the safety the value of the *last*
>> duplicate local variable in the list (the first in the reversed list), but
>> `hack-local-variables' uses an unchecked value of the *first* duplicate
>> local variable.
>
> Hopefully, this is a false alarm. I can't find a recipe to reproduce this.
Sometimes it's even more safe than necessary. When .dir-locals.el
contains a variable with an unsafe value, but file-local variables contain
a safe value of the same variable, it asks confirmation for the unsafe
directory-local value, but really uses the safe file-local variable's value.
I think this is not a problem. It seems better to remind the user that
.dir-locals.el contains an unsafe value.
--
Juri Linkov
http://www.jurta.org/emacs/
prev parent reply other threads:[~2009-12-15 0:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 18:24 file local variables Francesc Rocher
2009-12-14 21:29 ` Juri Linkov
2009-12-14 22:26 ` Francesc Rocher
2009-12-14 21:34 ` Juri Linkov
2009-12-14 23:39 ` Juri Linkov
2009-12-15 0:20 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4wpyrbv.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).