From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.emacs.devel Subject: Re: [patch] fix "in file included from" with gcc Date: Mon, 11 Jan 2010 09:58:09 +1100 Organization: Bah Humbug Message-ID: <87k4vp5zzy.fsf@blah.blah> References: <4B495D24.9010200@censorshipresearch.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1263164344 23265 80.91.229.12 (10 Jan 2010 22:59:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Jan 2010 22:59:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 10 23:58:56 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NU6kK-0002nt-IT for ged-emacs-devel@m.gmane.org; Sun, 10 Jan 2010 23:58:56 +0100 Original-Received: from localhost ([127.0.0.1]:35146 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NU6kL-0006eN-65 for ged-emacs-devel@m.gmane.org; Sun, 10 Jan 2010 17:58:57 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NU6k5-0006X9-Os for emacs-devel@gnu.org; Sun, 10 Jan 2010 17:58:41 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NU6k1-0006UW-An for emacs-devel@gnu.org; Sun, 10 Jan 2010 17:58:41 -0500 Original-Received: from [199.232.76.173] (port=51850 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NU6k0-0006U8-Pe for emacs-devel@gnu.org; Sun, 10 Jan 2010 17:58:37 -0500 Original-Received: from mailout1-12.pacific.net.au ([125.255.80.131]:58218 helo=mailout1.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NU6k0-0002js-5N for emacs-devel@gnu.org; Sun, 10 Jan 2010 17:58:36 -0500 Original-Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id D72FE5155A4; Mon, 11 Jan 2010 09:58:29 +1100 (EST) Original-Received: from blah.blah (ppp268B.dyn.pacific.net.au [61.8.38.139]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id 45FEB2742A; Mon, 11 Jan 2010 09:58:29 +1100 (EST) Original-Received: from gg by blah.blah with local (Exim 4.71) (envelope-from ) id 1NU6ja-00028b-2D; Mon, 11 Jan 2010 09:58:10 +1100 In-Reply-To: <4B495D24.9010200@censorshipresearch.org> (Daniel Colascione's message of "Sat, 09 Jan 2010 23:52:52 -0500") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:119799 Archived-At: Daniel Colascione writes: > > Also, the original comment notwithstanding, it only seems to work when > we match > "in file included from" *before* we match the gnu style. This is http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3965 Last time I checked the gcc-include part had got better by itself somehow. The basic problem is the omake bit. It really ought to be driven only by a symbol in compilation-error-regexp-alist, or alternately there ought to be a cap on how many spaces worth of indentation it matches, as surely it can't be meant to hit a big indent like the gcc-include.