From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: (insert ?\n) spuriously calls before-change-functions twice. Help! Date: Tue, 19 Jan 2010 10:11:47 -0500 Message-ID: <87k4verux8.fsf@stupidchicken.com> References: <20100105110954.GA2639@muc.de> <20100105173158.GB2639@muc.de> <20100119132316.GA1171@muc.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1263914017 23853 80.91.229.12 (19 Jan 2010 15:13:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Jan 2010 15:13:37 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 19 16:13:29 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NXFkN-0004Yy-P0 for ged-emacs-devel@m.gmane.org; Tue, 19 Jan 2010 16:12:00 +0100 Original-Received: from localhost ([127.0.0.1]:37585 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXFkO-00014t-JA for ged-emacs-devel@m.gmane.org; Tue, 19 Jan 2010 10:12:00 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NXFkJ-00014V-FO for emacs-devel@gnu.org; Tue, 19 Jan 2010 10:11:55 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NXFkE-000147-J0 for emacs-devel@gnu.org; Tue, 19 Jan 2010 10:11:54 -0500 Original-Received: from [199.232.76.173] (port=41019 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXFkE-000144-Fr for emacs-devel@gnu.org; Tue, 19 Jan 2010 10:11:50 -0500 Original-Received: from pantheon-po29.its.yale.edu ([130.132.50.124]:40350) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NXFkE-0006eN-6n for emacs-devel@gnu.org; Tue, 19 Jan 2010 10:11:50 -0500 Original-Received: from furry (adsl-99-58-201-143.dsl.wlfrct.sbcglobal.net [99.58.201.143]) (authenticated bits=0) by pantheon-po29.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0JFBmww028205 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 19 Jan 2010 10:11:48 -0500 Original-Received: by furry (Postfix, from userid 1000) id 758A7C05D; Tue, 19 Jan 2010 08:11:47 -0700 (MST) In-Reply-To: <20100119132316.GA1171@muc.de> (Alan Mackenzie's message of "Tue, 19 Jan 2010 13:23:16 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:120230 Archived-At: Alan Mackenzie writes: >> > There doesn't seem to be any system in where the two change hooks are >> > invoked. For example, insert directly calls signal_after_change, yet not >> > signal_before_change; surely invocations of these should be paired. > >> Agreed. Patch very welcome, > > DONE. Specifically, revision 99376, fixing set_text_properties in > textprop.c. Please commit a ChangeLog entry as well.