From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: W Dan Meyer Newsgroups: gmane.emacs.devel Subject: Re: support for git commit --amend/--signoff Date: Sat, 12 Jun 2010 00:48:44 +0100 Message-ID: <87k4q55dwj.fsf@gmail.com> References: <87hblavx6f.fsf@mail.jurta.org> <87iq5ptu73.fsf@mail.jurta.org> <87hbl9qp2b.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1276300154 10132 80.91.229.12 (11 Jun 2010 23:49:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 11 Jun 2010 23:49:14 +0000 (UTC) Cc: Dan Nicolaescu , Stefan Monnier , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 12 01:49:12 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ONDyI-0004zK-HR for ged-emacs-devel@m.gmane.org; Sat, 12 Jun 2010 01:49:10 +0200 Original-Received: from localhost ([127.0.0.1]:51864 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONDyH-0004UT-V8 for ged-emacs-devel@m.gmane.org; Fri, 11 Jun 2010 19:49:09 -0400 Original-Received: from [140.186.70.92] (port=53820 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONDyB-0004Sr-Bc for emacs-devel@gnu.org; Fri, 11 Jun 2010 19:49:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ONDy9-0008IL-Vz for emacs-devel@gnu.org; Fri, 11 Jun 2010 19:49:03 -0400 Original-Received: from mail-ww0-f41.google.com ([74.125.82.41]:39022) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONDy9-0008IC-QB; Fri, 11 Jun 2010 19:49:01 -0400 Original-Received: by wwb34 with SMTP id 34so1439078wwb.0 for ; Fri, 11 Jun 2010 16:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=JiI56iNCXJHQj0f5bP3zh6lnYajmcvyqXghCtjn6z1c=; b=TrxZHsiL9La6NhqmLTcIYxssbTVQVHko6G5jhUsoi+t4+l/Z9fI5ttM84CIQ4pS4FX LdoGU7ewlhJySVWrQ4UaxsKRU+9dW/Q2GA6s/mdig/D6fYtuELHUgmeUBAngUoWf+F2W G/vt6dFP5x5xbOYFoeonhuC/qndhRA4Z7rPlE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=OXcWah5dqek99NPYvFMNGRWQcsooncvp7YwAU8uPgFaB5Osejm0ssro2YBTt6iz1ew 3sdLxeh3FzHUwtFHMC3KkOr8HzTRWP1vFcC0PML175dOdOx9GwRr+o/KibnYjRcB34Dy KWOj2uOuQZDZbm9omUgHn0ULomS8lx3XrinJY= Original-Received: by 10.227.135.6 with SMTP id l6mr2577873wbt.60.1276300140415; Fri, 11 Jun 2010 16:49:00 -0700 (PDT) Original-Received: from spec-desktop.specuu.com (host86-137-132-199.range86-137.btcentralplus.com [86.137.132.199]) by mx.google.com with ESMTPS id t15sm13208166wbc.5.2010.06.11.16.48.59 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 11 Jun 2010 16:48:59 -0700 (PDT) In-Reply-To: <87hbl9qp2b.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 11 Jun 2010 23:38:04 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125775 Archived-At: Juri Linkov writes: >>> Arguments: --amend --signoff >>> >>> This will provide interchangeability: the user will be able to copy >>> arguments from the *VC-log* buffer to the external command line and >>> back to the *VC-log* buffer to construct the necessary command line. >> >> That's very ugly from the UI point of view, it's not better than doing >> the same thing from the command line directly. > > In Emacs it's easier to select files and to write a log message > than doing the same in the command line. > > But currently vc mode is limited to a small set of supported arguments. > Allowing to specify the command line arguments will give the user the > full power of the command line when doing vc operations from Emacs. Before I started using VC for real, I used to issue (and I still do it sometimes), M-&, and just type the vcs command - this way I've had a some completion, asynchronous command and output in a separate buffer. Maybe something like C-x g . would be good but: - with completion of possible commands (the interface is not really different, it is always a driver name and then token representing command) - adjusting the output (choosing output buffer mode, being quiet, etc.) - being quiet and synchronous for some class of commands This would be based on the assumption that almost every time. `log' command produces log, diff produces `diff' and `rm' could be silent and not show the buffer (plus it could be possibly synchronous). So adjusting those two things (completion and processing output) would give certain advantages but allowed user to type any flavour of command he wished. BTW: There could be in Emacs sort of way of specifying grammar for parsing command-line commands apart from usual user interfaces. It could be generated from -h. That could allow completion with online help, and if the format is -h standarised enough even completion of certain types of entries. (Like ). > >> More, for --amend it's desirable to copy the contents of the original >> log in the *VC-log* buffer, so that the user can edit it, and check in >> the modified version. > > Maybe, --amend is a special case that requires special processing. > But generally it's also desirable to be able to specify the command line > arguments from the *VC-log* buffer. Wojciech