From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Engster Newsgroups: gmane.emacs.devel Subject: CEDET non-regression bug fixes Date: Tue, 13 Nov 2012 21:52:19 +0100 Message-ID: <87k3tprzss.fsf@engster.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1352839966 26028 80.91.229.3 (13 Nov 2012 20:52:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Nov 2012 20:52:46 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 13 21:52:56 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TYNTW-0008RF-FP for ged-emacs-devel@m.gmane.org; Tue, 13 Nov 2012 21:52:50 +0100 Original-Received: from localhost ([::1]:54613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYNTM-0001Mf-JX for ged-emacs-devel@m.gmane.org; Tue, 13 Nov 2012 15:52:40 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYNTH-0001MA-On for emacs-devel@gnu.org; Tue, 13 Nov 2012 15:52:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYNTE-0007Dc-Mi for emacs-devel@gnu.org; Tue, 13 Nov 2012 15:52:35 -0500 Original-Received: from randomsample.de ([83.169.19.17]:37955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYNTE-0007CM-A4 for emacs-devel@gnu.org; Tue, 13 Nov 2012 15:52:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=7eNqTVwNQRZLoPo7YOW9AKoEd+x5Id/znrHNJwy+fIA=; b=uvfPRpOhFffrwxeJgZpCagBRLITk8L72/wCZddcbFzvHtLf2CV0fRX6IPnoUGjmqoIW3gT44PGA8a7zjVPYTfJdXVS4xHhK8zOAP8xPy58ajsRprhgAYsTapgJEKZnQh; Original-Received: from dslc-082-083-048-098.pools.arcor-ip.net ([82.83.48.98] helo=spaten) by randomsample.de with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TYNT2-0008Oy-Qc for emacs-devel@gnu.org; Tue, 13 Nov 2012 21:52:21 +0100 User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) Mail-Followup-To: emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 83.169.19.17 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154856 Archived-At: --=-=-= Content-Type: text/plain I'm asking for permission to apply the following CEDET non-regression bug fixes to the emacs-24 branch. They fix some pretty annoying bugs but are so small that I think they should be safe to commit. - Patch1: Fixes a bug where C++ system headers like "vector" are not recognized as C++ and hence parsing fails. The bug was that `enable-local-variables' was erronously set to 'nil' when loading those files, but it should be ':safe', so that the magic comments are recognized. - Patch2: Without this fix, the interactive function `semantic-symref-symbol' simply does not work at all, so it cannot possibly make anything worse. - Patch3: Move to beginning of completions when pressing TAB at the end of the Completions buffer. - Patch4: Fixes a very annoying, long-standing bug were active buffers were killed when using GNU global and file was loaded through a symlink. -David --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=patch1.patch === modified file 'lisp/cedet/semantic/fw.el' --- lisp/cedet/semantic/fw.el 2012-10-07 12:07:12 +0000 +++ lisp/cedet/semantic/fw.el 2012-10-27 19:55:04 +0000 @@ -421,14 +421,7 @@ ;; Don't prompt to insert a template if we visit an empty file (auto-insert nil) ;; We don't want emacs to query about unsafe local variables - (enable-local-variables - (if (featurep 'xemacs) - ;; XEmacs only has nil as an option? - nil - ;; Emacs 23 has the spiffy :safe option, nil otherwise. - (if (>= emacs-major-version 22) - nil - :safe))) + (enable-local-variables :safe) ;; ... or eval variables (enable-local-eval nil) ) --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=patch2.patch === modified file 'lisp/cedet/semantic/symref/list.el' --- lisp/cedet/semantic/symref/list.el 2012-09-02 18:37:45 +0000 +++ lisp/cedet/semantic/symref/list.el 2012-11-04 21:03:27 +0000 @@ -69,7 +69,7 @@ references are organized by file and the name of the function they are used in. Display the references in `semantic-symref-results-mode'." - (interactive (list (semantic-tag-name (semantic-complete-read-tag-buffer-deep + (interactive (list (semantic-tag-name (semantic-complete-read-tag-project "Symrefs for: ")))) (semantic-fetch-tags) (let ((res nil) --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=patch3.patch === modified file 'lisp/cedet/semantic/complete.el' --- lisp/cedet/semantic/complete.el 2012-10-12 19:56:34 +0000 +++ lisp/cedet/semantic/complete.el 2012-11-04 21:06:33 +0000 @@ -1340,7 +1343,10 @@ (defmethod semantic-displayor-scroll-request ((obj semantic-displayor-abstract)) "A request to for the displayor to scroll the completion list (if needed)." - (scroll-other-window)) + (with-selected-window (get-buffer-window "*Completions*") + (if (posn-at-point (point-max)) + (goto-char (point-min)) + (scroll-up)))) (defmethod semantic-displayor-focus-previous ((obj semantic-displayor-abstract)) "Set the current focus to the previous item." --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=patch4.patch === modified file 'lisp/cedet/semantic/symref.el' --- lisp/cedet/semantic/symref.el 2012-09-02 16:59:23 +0000 +++ lisp/cedet/semantic/symref.el 2012-11-06 16:35:07 +0000 @@ -356,7 +356,7 @@ (lambda (hit) (let* ((line (car hit)) (file (cdr hit)) - (buff (get-file-buffer file)) + (buff (find-buffer-visiting file)) (tag nil) ) (cond --=-=-=--